-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant IAM rights to service identities in host project #1542
Merged
wiktorn
merged 10 commits into
GoogleCloudPlatform:master
from
wiktorn:project_iam_magic
Jul 29, 2023
Merged
Grant IAM rights to service identities in host project #1542
wiktorn
merged 10 commits into
GoogleCloudPlatform:master
from
wiktorn:project_iam_magic
Jul 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
juliocc
approved these changes
Jul 28, 2023
juliocc
reviewed
Jul 28, 2023
ludoo
reviewed
Jul 28, 2023
ludoo
reviewed
Jul 28, 2023
ludoo
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, dropped a couple comments but I really like this!
wiktorn
commented
Jul 29, 2023
wiktorn
force-pushed
the
project_iam_magic
branch
from
July 29, 2023 17:40
ba2da80
to
012a9b2
Compare
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow granting IAM permissions in Shared VPC host project based on list of services to be used in service project.
project-factory
blueprintCloses: #1527, #1526, #1518