Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant IAM rights to service identities in host project #1542

Merged
merged 10 commits into from
Jul 29, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Jul 28, 2023

Allow granting IAM permissions in Shared VPC host project based on list of services to be used in service project.

  • leverage this functionality in project-factory blueprint

Closes: #1527, #1526, #1518

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

modules/project/shared-vpc.tf Outdated Show resolved Hide resolved
modules/project/shared-vpc.tf Outdated Show resolved Hide resolved
modules/project/variables.tf Outdated Show resolved Hide resolved
modules/project/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, dropped a couple comments but I really like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tentative] Automate shared VPC role grants for service identities
3 participants