Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: network user for dataflow service agent #1526

Conversation

ericyz
Copy link

@ericyz ericyz commented Jul 27, 2023

Add the IAM permission to support dataflow workers running on shared VPC host network

@ericyz ericyz force-pushed the feat/project-factory-dataflow branch from 802a6cd to 93b7b85 Compare July 27, 2023 03:18
@ericyz
Copy link
Author

ericyz commented Jul 27, 2023

Please help to review

@wiktorn
Copy link
Collaborator

wiktorn commented Jul 27, 2023

Thank you Eric for this. I think we are still missing few other resources on the list here:

And I might still miss some of them.

@juliocc
Copy link
Collaborator

juliocc commented Jul 27, 2023

The right way to approach this would be to expose shared_vpc_service_config.service_identity_iam as a field in the project factory yaml.

Please see this comment

@wiktorn
Copy link
Collaborator

wiktorn commented Jul 29, 2023

Closing as implemented using a bit different approach in #1542

@wiktorn wiktorn closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants