added reverse lookup feature to module dns #1042 #1043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1042
I've missed reverse lookup feature at dns modules while using cloud foundation fabric.
Basically i've added a new type in variables.tf file called reverse and I've changed google_dns_managed_zone. non-public adding reverse_lookup attribute set to var.type=="reverse" in that way if type is differente to reverse it will be false and only when setting it to reverse the value will be true and will create the required reverse zone.
I've modified as well README.md file to add an example and new type.
I've run already tfdoc and tests as per your contributing guide.
Regards