Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added reverse lookup feature to module dns #1042 #1043

Merged

Conversation

chemapolo
Copy link
Contributor

#1042

I've missed reverse lookup feature at dns modules while using cloud foundation fabric.

Basically i've added a new type in variables.tf file called reverse and I've changed google_dns_managed_zone. non-public adding reverse_lookup attribute set to var.type=="reverse" in that way if type is differente to reverse it will be false and only when setting it to reverse the value will be true and will create the required reverse zone.

I've modified as well README.md file to add an example and new type.

I've run already tfdoc and tests as per your contributing guide.

Regards

@google-cla
Copy link

google-cla bot commented Dec 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc juliocc self-requested a review December 8, 2022 12:55
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super-clean PR, thanks a lot!

One trivial doubt: should we use reverse-managed instead of reverse, to indicate that custom reverse zones are a different thing and use the private type?

@chemapolo
Copy link
Contributor Author

chemapolo commented Dec 8, 2022

Super-clean PR, thanks a lot!

One trivial doubt: should we use reverse-managed instead of reverse, to indicate that custom reverse zones are a different thing and use the private type?

No prob ill change it, i've seen that by mistake I left ${reverse-ip}.in-addr.arpa. in the readme example instead of an ip. im going to change it and commit with your suggestion 'reverse-managed' Thanks a lot!

@ludoo ludoo merged commit 9786dc4 into GoogleCloudPlatform:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants