Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse lookup dns zone #1042

Closed
chemapolo opened this issue Dec 8, 2022 · 2 comments
Closed

Reverse lookup dns zone #1042

chemapolo opened this issue Dec 8, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@chemapolo
Copy link
Contributor

I'm missing reverse lookup private zone feature at the dns module.

it is already supported by Google-beta provider :

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/dns_managed_zone#reverse_lookup

https://cloud.google.com/dns/docs/zones/managed-reverse-lookup-zones?hl=es-419
@chemapolo chemapolo mentioned this issue Dec 8, 2022
Merged
@ludoo
Copy link
Collaborator

ludoo commented Dec 8, 2022

I completely missed this, nice feature and thanks for flagging this and sending a PR!

@ludoo ludoo added the enhancement New feature or request label Dec 8, 2022
@chemapolo
Copy link
Contributor Author

Allways a pleasure to collaborate, im going to change as per your request to reverse-managed and commit the changes. Thanks a lot.

ludoo added a commit that referenced this issue Dec 8, 2022
@chemapolo @ludoo
added reverse lookup feature to module dns #1042 (#1043)
9786dc4 
* added reverse lookup feature to module dns

* corrected readme example passed tfdoc and tests

Co-authored-by: Ludovico Magnocavallo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ludoo @chemapolo