notice when app engine java components aren't installed #206

elharo · 2016-09-07T19:07:32Z

meltsufin · 2016-09-07T19:15:54Z

src/main/java/com/google/cloud/tools/appengine/cloudsdk/CloudSdk.java

@@ -59,6 +59,7 @@
  private static final String DEV_APPSERVER_PY = "bin/dev_appserver.py";
  private static final String JAVA_APPENGINE_SDK_PATH =
      "platform/google_appengine/google/appengine/tools/java/lib";
+  private static final String JAVA_COMPONENTS_PATH = "platform/gcd/.appengine";


Is it sufficient to just check for the existence of JAVA_APPENGINE_SDK_PATH?

No, that seems to exist regardless

We should probably check with the Cloud SDK team to see what they recommend using.

Would executing and parsing a gcloud components list be overkill?

@markpell, @znewman01 can you comment on this?

We want to know whether or not the user ran:

gcloud components install app-engine-java

We've seen multiple user reports that trace back to not having done this.
This directory appears to be added/removed when the user installs/removes the component.

FWIW: ~~although my installation is out of date, I did have app-engine-java, but~~ just updated and I don't have anything in platform/gcd.

Since what we're actually using is the appengine-tools-api.jar, we should probably just check for its existence.

So again, this is just checking for the wrong thing. That directory is for the legacy datastore emulator which has nothing to do with Java or any Java components.

How far are we from having the requiring staging code as separate artifacts on maven central? I don't think it's appropriate for the plugin to be grabbing individual jars from the SDK as this is not a public interface.

@ludoch who would know when staging is going to make it to maven central.

To summarize what's being discussed:

For component detection we should be calling gcloud components list and not digging into the cloud SDK packaged files.

The staging question is not related to this CL but we are working on moving as many deps as possible away from using Cloud SDK paths.

elharo · 2016-09-07T20:11:03Z

$ gcloud components list --format='value(state)' --filter=id:app-engine-java

Your current Cloud SDK version is: 124.0.0
The latest available version is: 125.0.0

name=Not Installed

briandealwis · 2016-09-07T20:16:01Z

$ gcloud components list --format='value(state)' --filter=id:app-engine-java

Your current Cloud SDK version is: 119.0.0
The latest available version is: 125.0.0

name=Update Available

Hmm, I should update.

etanshaul · 2016-09-07T20:17:26Z

I think you'd want to set --format=json

patflynn · 2016-09-07T20:20:56Z

src/main/java/com/google/cloud/tools/appengine/cloudsdk/CloudSdk.java

@@ -262,6 +268,10 @@ public void validate() throws AppEngineException {
          "Validation Error: Java Tools jar location '"
              + JAR_LOCATIONS.get(JAVA_TOOLS_JAR) + "' is not a file.");
    }
+    if (!Files.isDirectory(getJavaAppEngineComponentsPath())) {


my concern about having this here is that we can support deploy without needing the java components installed. A client should be able to get configure gcloud and do a deployment without install the components,

Right, this only applies to Standard and Compat deployments, not pure Flex.

elharo · 2016-09-07T22:35:14Z

$ gcloud components list --format='json' --filter=id:app-engine-java

Your current Cloud SDK version is: 124.0.0
The latest available version is: 125.0.0

[
{
"current_version_string": null,
"id": "app-engine-java",
"is_configuration": false,
"is_hidden": false,
"latest_version_string": "1.9.42",
"name": "gcloud app Java Extensions",
"size": 142219489,
"state": {
"name": "Not Installed"
}
}
]

It really shouldn't be saying

Your current Cloud SDK version is: 124.0.0
The latest available version is: 125.0.0

znewman01 · 2016-09-08T01:12:27Z

It's only printing that to STDERR; it's very easy to ignore.

On Wed, Sep 7, 2016 at 6:35 PM, Elliotte Rusty Harold <
[email protected]> wrote:

$ gcloud components list --format='json' --filter=id:app-engine-java

Your current Cloud SDK version is: 124.0.0
The latest available version is: 125.0.0

[
{
"current_version_string": null,
"id": "app-engine-java",
"is_configuration": false,
"is_hidden": false,
"latest_version_string": "1.9.42",
"name": "gcloud app Java Extensions",
"size": 142219489,
"state": {
"name": "Not Installed"
}
}
]

It really shouldn't be saying

Your current Cloud SDK version is: 124.0.0
The latest available version is: 125.0.0

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#206 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1VgZViWTpb33--gZgqPCvRJvDjYvUAks5qnzwjgaJpZM4J3QGM
.

patflynn · 2016-09-08T15:50:31Z

@elharo are we closing this to start over?

elharo · 2016-09-08T17:47:34Z

Yes, the version that calls gcloud components shares very little with this branch.

elharo · 2016-09-12T16:57:13Z

reopening since we may do this

…ins-core into i165B

Elliotte Rusty Harold added 2 commits September 7, 2016 14:14

@OverRide

a90fcf3

notice when app engine java components aren't installed

3c470fd

googlebot added the cla: yes label Sep 7, 2016

Merge branch 'master' into i165B

7c7406e

meltsufin reviewed Sep 7, 2016
View reviewed changes

Merge branch 'master' into i165

301fcad

patflynn reviewed Sep 7, 2016
View reviewed changes

Elliotte Rusty Harold added 5 commits September 8, 2016 07:21

use gcloud components list to look for app engine java components

585f1ca

Merge branch 'i165' into i165b

19503f7

use gcloud components list to look for app engine java components

a78d87b

use gcloud components list to look for app engine java components

34580ab

fix up tests

29147b0

elharo closed this Sep 8, 2016

Elliotte Rusty Harold added 5 commits September 8, 2016 12:07

parse JSON response

b776b12

gcloud returns JSON arrays

c70ea33

add exception javadoc

7d5e3a2

push stdOut collection into ProcessRunner

e9083c2

Merge branch 'master' into i165b

03f93f9

Elliotte Rusty Harold added 3 commits September 8, 2016 14:49

checkstyle fixes

d1904ae

install cloud sdk for integration tests

e21364a

add gcloud to path

b6fc0ed

elharo reopened this Sep 12, 2016

Elliotte Rusty Harold added 2 commits September 12, 2016 13:06

look for different file

97da3d0

Merge branch 'i165B' of github.com:GoogleCloudPlatform/appengine-plug…

124642d

…ins-core into i165B

elharo closed this Sep 12, 2016

loosebazooka deleted the i165B branch April 4, 2017 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

notice when app engine java components aren't installed #206

notice when app engine java components aren't installed #206

elharo commented Sep 7, 2016

meltsufin Sep 7, 2016 •

edited

Loading

elharo Sep 7, 2016

meltsufin Sep 7, 2016

etanshaul Sep 7, 2016

meltsufin Sep 7, 2016

elharo Sep 7, 2016

briandealwis Sep 7, 2016 •

edited

Loading

meltsufin Sep 7, 2016

markpell Sep 7, 2016

patflynn Sep 7, 2016

elharo commented Sep 7, 2016

briandealwis commented Sep 7, 2016

etanshaul commented Sep 7, 2016

patflynn Sep 7, 2016

meltsufin Sep 7, 2016

elharo commented Sep 7, 2016

znewman01 commented Sep 8, 2016

patflynn commented Sep 8, 2016

elharo commented Sep 8, 2016

elharo commented Sep 12, 2016

notice when app engine java components aren't installed #206

notice when app engine java components aren't installed #206

Conversation

elharo commented Sep 7, 2016

meltsufin Sep 7, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

briandealwis Sep 7, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elharo commented Sep 7, 2016

briandealwis commented Sep 7, 2016

etanshaul commented Sep 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elharo commented Sep 7, 2016

znewman01 commented Sep 8, 2016

patflynn commented Sep 8, 2016

elharo commented Sep 8, 2016

elharo commented Sep 12, 2016

meltsufin Sep 7, 2016 •

edited

Loading

briandealwis Sep 7, 2016 •

edited

Loading