Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more specific error when missing app-engine-java gcloud component #165

Closed
etanshaul opened this issue Jul 14, 2016 · 3 comments
Closed

Provide more specific error when missing app-engine-java gcloud component #165

etanshaul opened this issue Jul 14, 2016 · 3 comments
Assignees
@elharo

Comments

@etanshaul
Copy link
Contributor

It would be nice if the library threw a specific exception if appcfg was unavailable (via the gcloud component). Currently this is what users are shown:

Error: Could not find or load main class com.google.appengine.tools.admin.AppCfg
Failed to deploy 'app-engine-random-service:war exploded': Deployment failed due to an unexpected error while staging the project.
@etanshaul etanshaul mentioned this issue Jul 14, 2016
Closed
@joaoandremartins joaoandremartins mentioned this issue Jul 15, 2016
Merged
@etanshaul etanshaul mentioned this issue Sep 6, 2016
Closed
@elharo
Copy link
Contributor

elharo commented Sep 7, 2016

To be clear, the problem is that the user has not run

gcloud components install app-engine-java

As an initial fix, I suggest throwing a specific exception in this case so that IDEs and other tools can alert the user in the way appropriate to their environment: error dialog. System.out (maven), etc.

Longer term, I'd like to either bundle this or install it automatically if necessary.

@elharo elharo self-assigned this Sep 7, 2016
@elharo elharo mentioned this issue Sep 7, 2016
Closed
@elharo
Copy link
Contributor

elharo commented Sep 7, 2016

probably do this in com.google.cloud.tools.appengine.cloudsdk.CloudSdk

This was referenced Sep 7, 2016
Closed
Closed
@elharo
Copy link
Contributor

elharo commented Apr 30, 2018

We've had AppEngineJavaComponentsNotInstalledException for a long time now.

@elharo elharo closed this as completed Apr 30, 2018
JoeWang1127 pushed a commit that referenced this issue Nov 29, 2023
@akerekes
Fixes: #158 - dev appserver 1 stuff and #164 - Stop should generate a…
e71b362 
… configuration based on dev appserver 1 or 2-alpha. (#165)

* WIP - Fixes #158 - dev appserver 1 stuff

* javadoc and simpler code whether checking <services> parameter has been configured by the user

* remove default value from appYamls, revert file->path change

* unit tests for RunMojo

* update appengine-plugins-core dependency to 0.3.0

* try to fix kokoro test

* use custom ports to test run in integration test to avoid port clash on Kokoro

* fix async run test as well for Kokoro

* Fixes #158 - dev appserver 1 stuff

* additional tests

* add datastorePath to RunMojo

* add javadoc to datastorePath

* increase timeout to see if it fixes the kokoro-ubuntu build

* reformat pom.xml dependency for junitparams, rename SupportedVersion to SupportedDevServerVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elharo elharo

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elharo @etanshaul