Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #241 - fix deferred authentication for Java21 EE10 runtime #243

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

lachlan-roberts
Copy link
Collaborator

closes #241

If request.getUserPrincipal() was being called on a request with deferred authentication, then authentication was failing.

This is because the isDeferred check in EE10AppEngineAuthentication was in the wrong place.

@copybara-service copybara-service bot merged commit 6ee9c31 into main Jul 3, 2024
8 of 9 checks passed
@copybara-service copybara-service bot deleted the deferredAuthentication branch July 3, 2024 15:51
@ludoch
Copy link
Collaborator

ludoch commented Jul 3, 2024

Code fix is now checked in.
Will reach prod end of next week or next (due to 4rth of July break in US).
Meanwhile, you can try following for the next few days https://github.com/GoogleCloudPlatform/appengine-java-standard/blob/main/TRYLATESTBITSINPROD.md from head (Sorry, Maven only, gradle contribution welcome).

srinjoyray pushed a commit that referenced this pull request Nov 12, 2024
PiperOrigin-RevId: 649089202
Change-Id: I4a8d4c9b0c0787dba3f88209ad9eed238d3feb57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java 21 regression bug: in a .jsp, request.getUserPrincipal() returns null despite being logged in
2 participants