Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 21 regression bug: in a .jsp, request.getUserPrincipal() returns null despite being logged in #241

Closed
cyril-briquet opened this issue Jul 2, 2024 · 11 comments · Fixed by #243
Assignees

Comments

@cyril-briquet
Copy link

When setting java21 in appengine-web.xml,
in a .jsp, the call request.getUserPrincipal() returns null despite being logged in.

@ludoch ludoch self-assigned this Jul 2, 2024
@ludoch
Copy link
Collaborator

ludoch commented Jul 2, 2024

Both prod and local server?

@cyril-briquet
Copy link
Author

Local server yes; production server I haven't tried.

@cyril-briquet
Copy link
Author

Both prod and local server?

I've just tried on a prod server: the answer is yes, both indeed.

@lachlan-roberts
Copy link
Collaborator

Opened PR #243 to fix this.

@ludoch
Copy link
Collaborator

ludoch commented Jul 3, 2024

Code fix is now checked in.
Will reach prod end of next week or next (due to 4rth of July break in US).
Meanwhile, you can try following for the next few days https://github.com/GoogleCloudPlatform/appengine-java-standard/blob/main/TRYLATESTBITSINPROD.md from head (Sorry, Maven only, gradle contribution welcome).

@cyril-briquet
Copy link
Author

Update: bug is fixed in local devserver, but not in production server

@ludoch
Copy link
Collaborator

ludoch commented Aug 4, 2024

A bit strange as the code area for the fix also applies to prod... Maybe one thing to try first is to go to the admin console, app engine instances page and try to kill whatever running instance you see to force a restart?

Restarts are not automatically done anymore...

@cyril-briquet
Copy link
Author

Thanks for your rapid answer.

As suggested, I went to the admin console, AE instances page and killed the one instance that was running (apparently, it always restarts automatically even before I try to access the app in production as a user).

FWIW, here is the code that correctly displays the user's e-mail with the dev server and null with the prod server:

<%= (request.getUserPrincipal() != null) ? request.getUserPrincipal().getName() : "null" %>

@ludoch
Copy link
Collaborator

ludoch commented Aug 5, 2024

Thanks!
Sorry about that, we believe 3d53db9 should address it. Tested only manually, looking for a prod e2e test...

@cyril-briquet
Copy link
Author

test-files.txt

Please find here as an attached file the source code of a test web app exercising the bug

@cyril-briquet
Copy link
Author

Works for me: bug not observed any more on the production server.
Thanks for the patches.

srinjoyray pushed a commit that referenced this issue Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants