Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Conversation

cdanielsen
Copy link
Contributor

@cdanielsen cdanielsen commented Jan 24, 2018

Fixes #339

Revs a dependency that is a major version out of date, resulting in a downstream dependency on [email protected] which has an engines flag set to only allow installation in projects with a node.js version < 7.

vs

Use case: If someone is using [email protected], either directly or in their tree (say from create-react-app), and is specifying node 8 as their apps' minimum engines setting to enforce consistency, AND has the npm engine-strict=true flag set... npm install will fail.

npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for [email protected]: wanted: {"node":">=0.10.0 <7"} (current: {"node":"8.9.4","npm":"5.6.0"})
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Required: {"node":">=0.10.0 <7"}
npm ERR! notsup Actual:   {"npm":"5.6.0","node":"8.9.4"}

Feel free to tell me if this is a stupid/too narrow a use-case reason for a PR, but I thought I would give it a shot =)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@cdanielsen
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jeffposnick
Copy link
Contributor

Thanks, @cdanielsen!

@jeffposnick jeffposnick merged commit 2ee24a9 into GoogleChromeLabs:master Jan 24, 2018
@cdanielsen cdanielsen deleted the bump-update-notifier-to-fix-downstream-outdated-got-dependency branch January 24, 2018 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants