Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Because of dep on old update-notifier, unable to use with node 8 and engine-strict=true #339

Closed
markFromMST opened this issue Dec 5, 2017 · 3 comments

Comments

@markFromMST
Copy link

Currently there is a dep on update-notifier of 1.0.3, which then pulls in an old version of latest-version (2.0.0) which then pulls in an old version of package-json (2.4.0) which then pulls in an old version of got (5.7.1) which then only allows:

"engines": {
"node": ">=0.10.0 <7"
},

the latest version of got allows:

"engines": {
"node": ">=4"
},

@markFromMST
Copy link
Author

I cloned the repo, updated the dep and the unit tests pass. Strangely lint does not, but that is not related.

@jeffposnick
Copy link
Contributor

Thanks for investigating, @markFromMST! If you can put together a pull request that contains the updates to package.json, I'd be happy to review.

@cdanielsen
Copy link
Contributor

Should have consulted the issues first, but I made #344 independently for this exact issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants