Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Add a warning about editing the generated output #184

Merged
merged 2 commits into from
Sep 21, 2016
+14 −1
Merged

Add a warning about editing the generated output #184

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aef4bd
Add a warning about editing the generated output
jeffposnick Sep 19, 2016
3c4cf88
Review feedback
jeffposnick Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion service-worker.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,18 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
*/

// DO NOT EDIT THIS GENERATED OUTPUT DIRECTLY!
// This file should be overwritten as part of your build process.
// If you need to extend the behavior of the generated service worker, the best approach is to write
// additional code and include it using the importScripts option:
// https://github.com/GoogleChrome/sw-precache#importscripts-arraystring
// Alternatively, it's possible to make changes to the underlying template file and then use that as the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM. To improve readability can we introduce newlines (just an empty // line block) between 21-22, 24-25?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

// new base for generating output, via the templateFilePath option:
// https://github.com/GoogleChrome/sw-precache#templatefilepath-string
// If you go that route, make sure that whenever you update your sw-precache dependency, you reconcile any
// changes made to this original template file with your modified copy.

// This generated service worker JavaScript will precache your site's resources.
// The code needs to be saved in a .js file at the top-level of your site, and registered
Expand Down