This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Add a warning about editing the generated output #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyosmani
reviewed
Sep 21, 2016
| // If you need to extend the behavior of the generated service worker, the best approach is to write | ||
| // additional code and include it using the importScripts option: | ||
| // https://github.com/GoogleChrome/sw-precache#importscripts-arraystring | ||
| // Alternatively, it's possible to make changes to the underlying template file and then use that as the |
There was a problem hiding this comment.
Text LGTM. To improve readability can we introduce newlines (just an empty // line block) between 21-22, 24-25?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
CC: @jpmedley
We should still do a better job about explaining how to extend the service worker in the docs (see #49), but in the meantime, maybe this warning will decrease the chance of someone manually editing the generated output.