Allows automated builds #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Developers can use the `LLAMA_PACK_KEYSTORE_PASSWORD` and `LLAMA_PACK_KEY_PASSWORD` enviroment variables to set the keystore and key passwords. - When both passwords are set, they will be used instead of prompting the users for the passwords.
PEConn
reviewed
Jan 31, 2020
src/cli/cmds/build.ts
Outdated
| * @returns {Promise<[string, string]>} A promise with a tuple where the first item is they | ||
| * keystore password and the second is the key password. | ||
| */ | ||
| async function getPasswords(): Promise<[string, string]> { |
There was a problem hiding this comment.
Could you create a class/interface for this with keystorePassword and keyPassword as members?
src/cli/cmds/build.ts
Outdated
| console.log('Installing Android Build Tools. Please, read and accept the license agreement'); | ||
| await androidSdkTools.installBuildTools(); | ||
| if (envKeyPass !== undefined && envKeystorePass !== undefined) { | ||
| return [envKeystorePass, envKeyPass]; |
There was a problem hiding this comment.
Could you add a log line here saying something like "Using passwords set in the LLAMA_PACK_KEYSTORE_PASSWORD and LLAMA_PACK_KEY_PASSWORD environmental variables."?
PEConn
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLAMA_PACK_KEYSTORE_PASSWORDandLLAMA_PACK_KEY_PASSWORDenviroment variables to set thekeystore and key passwords.
prompting the users for the passwords.
Closes #30