Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow automating the build command. #30

Closed
PEConn opened this issue Nov 25, 2019 · 1 comment · Fixed by #91
Closed

Allow automating the build command. #30

PEConn opened this issue Nov 25, 2019 · 1 comment · Fixed by #91
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@PEConn
Copy link
Collaborator

PEConn commented Nov 25, 2019

Currently the build command asks for passwords interactively which makes it tricky for build to be run as part of an automated script.

We should allow passing the passwords as part of the command line invocation.
@PEConn PEConn mentioned this issue Nov 25, 2019
Merged
@andreban andreban added the enhancement New feature or request label Nov 25, 2019
@andreban
Copy link
Member

andreban commented Nov 25, 2019 •
edited
Loading

I'm thinking about some options here:

  1. Users set the passwords in twa-manifest.json
  2. Users set the passwords and environment variables
  3. Both. Environment variables have precedence over twa-manifest.json?

@andreban andreban added this to the 1.0.0 milestone Jan 28, 2020
@andreban andreban mentioned this issue Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Allows automated builds andreban/llama-pack
2 participants
@andreban @PEConn