Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes UnhandledPromiseRejection errors #60

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fixes UnhandledPromiseRejection errors #60

merged 1 commit into from
Jan 10, 2020

Conversation

andreban
Copy link
Member

Closes #59

@andreban andreban requested a review from PEConn January 10, 2020 10:25
PEConn
PEConn approved these changes Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the issue enough to be fully convinced that this fixes the bug, although the code looks fine and sensible, so LGTM

@andreban andreban merged commit 252a033 into GoogleChromeLabs:master Jan 10, 2020
@andreban andreban deleted the fix-promise-rejection branch February 13, 2020 08:15
@andreban andreban added the bug Something isn't working label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle Promise rejection correctly in TwaGenerator
2 participants
@andreban @PEConn