Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Promise rejection correctly in TwaGenerator #59

Closed
andreban opened this issue Jan 10, 2020 · 0 comments · Fixed by #60
Closed

Handle Promise rejection correctly in TwaGenerator #59

andreban opened this issue Jan 10, 2020 · 0 comments · Fixed by #60
Assignees
@andreban
Labels
bug Something isn't working

Comments

@andreban
Copy link
Member

Promise rejection is not being handled correction in the call to Promise.all, leading to UnhandledPromiseRejectionWarning messages.
@andreban andreban added the bug Something isn't working label Jan 10, 2020
@andreban andreban self-assigned this Jan 10, 2020
@andreban andreban mentioned this issue Jan 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreban andreban

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes UnhandledPromiseRejection errors andreban/llama-pack
1 participant
@andreban