Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add deprecation message for disable-device-emulation flag #8334

Merged
merged 3 commits into from
Apr 23, 2019
Merged

core: add deprecation message for disable-device-emulation flag #8334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e9ec2a
core: add deprecation message for disable-device-emulation flag
wardpeet Apr 16, 2019
8bf3502
update message
wardpeet Apr 16, 2019
143dd82
ts-ignore for master
brendankenny Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lighthouse-cli/bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ async function begin() {
cliFlags.outputPath = 'stdout';
}

// @ts-ignore - deprecation message for removed disableDeviceEmulation; can remove warning in v6.
if (cliFlags.disableDeviceEmulation) {
wardpeet marked this conversation as resolved.
Show resolved Hide resolved
log.warn('config', 'The "--disable-device-emulation" has been removed in v5.' +
' Please use "--emulated-form-factor=none" instead.');
}

if (cliFlags.extraHeaders) {
// TODO: LH.Flags.extraHeaders is actually a string at this point, but needs to be
// copied over to LH.Settings.extraHeaders, which is LH.Crdp.Network.Headers. Force
Expand Down