core: add deprecation message for disable-device-emulation flag #8334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It just occurred to me that we can do this after it's been removed too :) I propose tweaking the text slightly and cherry-picking this back to v4.3.1 if we ever publish a patch release |
|
Feel free to keep this PR around until a patch is going to be made or just close if seems unecessary. |
brendankenny
approved these changes
Apr 17, 2019
Closed
|
@brendankenny we could go for something more in your face https://www.npmjs.com/package/boxen. we could also pause and put some new lines below |
sounds terrible, let's not do that :D |
|
@patrickhulce does this work for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding small deprecation message for disableDeviceEmulation flag.
For more info chat with @patrickhulce 😄
Related Issues/PRs
#8289 (comment)