Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(proto): reduce proto configSettings to minimum needed #6424

Merged
merged 3 commits into from
Oct 30, 2018
Merged

misc(proto): reduce proto configSettings to minimum needed #6424

merged 3 commits into from
Oct 30, 2018

Conversation

exterkamp
Copy link
Member

Summary
Remove many of the configSettings from the proto definition.

Related Issues/PRs
moves #6202 along
fixes: #6309 (by deleting it from the proto)
closes: #6403

@exterkamp exterkamp changed the title misc(proto): Minify proto configSettings to minimum needed misc(proto): minify proto configSettings to minimum needed Oct 29, 2018
brendankenny
brendankenny approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

paulirish
paulirish approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top notch comments!

for commit message, 'minify' makes me think of something else. i'd suggest something like:

misc(proto): reduce configSettings expressed in proto to minimum

proto/lighthouse-result.proto Show resolved Hide resolved
lighthouse-core/lib/proto-preprocessor.js Outdated Show resolved Hide resolved
@exterkamp exterkamp changed the title misc(proto): minify proto configSettings to minimum needed misc(proto): reduce proto configSettings to minimum needed Oct 30, 2018
@exterkamp exterkamp mentioned this pull request Oct 30, 2018
Merged
@brendankenny brendankenny merged commit 88b2829 into master Oct 30, 2018
@brendankenny brendankenny deleted the minify-proto branch October 30, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configSettings.output can be list or string
4 participants
@exterkamp @paulirish @brendankenny @patrickhulce