clients: Output setting is always an array #6403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
connorjclark
requested changes
Oct 26, 2018
clients/lightrider-entry.js
Outdated
| @@ -49,7 +49,7 @@ async function runLighthouseInLR(connection, url, flags, {lrDevice, categoryIDs, | |||
| } | |||
|
|
|||
| // pre process the LHR for proto | |||
| if (flags.output === 'json' && typeof results.report === 'string') { | |||
| if (flags.output === ['json'] && typeof results.report === 'string') { | |||
There was a problem hiding this comment.
unfortunately this doesn't work, the equality operator here is checking references not value.
> const array = ['json'];
< undefined
> ['json'] === array
< false
> ['json'] == array
< false
will need to be more explicit
flags.output && flags.output.length === 1 && flags.output[0] === 'json'
There was a problem hiding this comment.
#saving me from myself
connorjclark
approved these changes
Oct 27, 2018
patrickhulce
suggested changes
Oct 27, 2018
|
You guys are re-reviewing too fast! 😃 I have to make other changes on LR before this is ready to merge. So I'll mark this as chillin' until I can coordinate with @paulirish about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed string only uses of output, changed to array only.
Related Issues/PRs
fixes: #6309