Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade lighthouse-logger to 2.0.1 #15282

Merged
merged 3 commits into from
Jul 20, 2023
Merged

deps: upgrade lighthouse-logger to 2.0.1 #15282

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
184e777
deps: upgrade `lighthouse-logger` to 2.0.0
adamraine Jul 17, 2023
3ad44f7
up
adamraine Jul 18, 2023
dcc3a5b
Merge branch 'main' into log-up-2
adamraine Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
"intl-messageformat": "^4.4.0",
"jpeg-js": "^0.4.4",
"js-library-detector": "^6.6.0",
"lighthouse-logger": "^1.4.1",
"lighthouse-logger": "^2.0.0",
"lighthouse-stack-packs": "1.11.0",
"lodash": "^4.17.21",
"lookup-closest-locale": "6.2.0",
Expand Down
34 changes: 0 additions & 34 deletions types/internal/lighthouse-logger.d.ts
View file
Open in desktop

This file was deleted.

10 changes: 9 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4938,14 +4938,22 @@ lie@~3.3.0:
dependencies:
immediate "~3.0.5"

lighthouse-logger@^1.0.0, lighthouse-logger@^1.4.1:
lighthouse-logger@^1.0.0:
version "1.4.1"
resolved "https://registry.yarnpkg.com/lighthouse-logger/-/lighthouse-logger-1.4.1.tgz#a076d7be80cbac16b9fdcd930379b03fff514699"
integrity sha512-VDZF31xGrLS1Zyf79/Xs6J9I08EVgJyz085MAt0G3Sh6nARFSUaM+IkuEZE9xZrLpTtzH1Qt9UzH/7kt9LnhZQ==
dependencies:
debug "^2.6.9"
marky "^1.2.2"

lighthouse-logger@^2.0.0:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like LH and chrome-launcher will be using different version of this package. In practice this should be fine since the important global state is stored in marky.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thinking through every possible permutation of people doing weird things with their deps, is there any chance this could cause a problem like we had with 10.3.0 or whatever? Would going through the pain of bumping chrome-launcher be worth it to avoid any trouble?

Copy link
Member Author

@adamraine adamraine Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So chrome launcher compiles to CJS, which means we would need to make a breaking release to chrome launcher or reintroduce CJS support to the logger.

Edit: I think it's worth the trouble, I just don't know which option is better
Edit2: Lol forgot we already did this GoogleChrome/chrome-launcher#302 (but not rls)

version "2.0.0"
resolved "https://registry.yarnpkg.com/lighthouse-logger/-/lighthouse-logger-2.0.0.tgz#37202bea0721a23a922c9e2b59f3ba1fb9c67648"
integrity sha512-DiUtWQ1vo4lSCSlvpWvbK1pDFmyD+xau/yFzfVT7k9J1/mtv7nQ7AeS74ryDjYbAXaPWphOGBQqoeDsN8U076g==
dependencies:
debug "^2.6.9"
marky "^1.2.2"

[email protected]:
version "1.5.7-beta"
resolved "https://registry.yarnpkg.com/lighthouse-plugin-publisher-ads/-/lighthouse-plugin-publisher-ads-1.5.7-beta.tgz#ac35b0d8f9ee01c774d45a18fee109cded6395ec"
Expand Down