deps: upgrade lighthouse-logger to 2.0.1
#15282
Conversation
yarn.lock
Outdated
| version "1.4.1" | ||
| resolved "https://registry.yarnpkg.com/lighthouse-logger/-/lighthouse-logger-1.4.1.tgz#a076d7be80cbac16b9fdcd930379b03fff514699" | ||
| integrity sha512-VDZF31xGrLS1Zyf79/Xs6J9I08EVgJyz085MAt0G3Sh6nARFSUaM+IkuEZE9xZrLpTtzH1Qt9UzH/7kt9LnhZQ== | ||
| dependencies: | ||
| debug "^2.6.9" | ||
| marky "^1.2.2" | ||
|
|
||
| lighthouse-logger@^2.0.0: |
There was a problem hiding this comment.
Looks like LH and chrome-launcher will be using different version of this package. In practice this should be fine since the important global state is stored in marky.
There was a problem hiding this comment.
Ok, thinking through every possible permutation of people doing weird things with their deps, is there any chance this could cause a problem like we had with 10.3.0 or whatever? Would going through the pain of bumping chrome-launcher be worth it to avoid any trouble?
There was a problem hiding this comment.
So chrome launcher compiles to CJS, which means we would need to make a breaking release to chrome launcher or reintroduce CJS support to the logger.
Edit: I think it's worth the trouble, I just don't know which option is better
Edit2: Lol forgot we already did this GoogleChrome/chrome-launcher#302 (but not rls)
adamraine
changed the title
lighthouse-logger to 2.0.0lighthouse-logger to 2.0.1
No need for the extra type declaration file now!