Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(listitem): mention li can be contained by a menu #13927

Merged
merged 5 commits into from
May 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lighthouse-core/audits/accessibility/listitem.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ const i18n = require('../../lib/i18n/i18n.js');

const UIStrings = {
/** Title of an accesibility audit that evaluates if any list item elements do not have list parent elements. This title is descriptive of the successful state and is shown to users when no user action is required. */
title: 'List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements',
title: 'List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements',
/** Title of an accesibility audit that evaluates if any list item elements do not have list parent elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
failureTitle: 'List items (`<li>`) are not contained within `<ul>` ' +
'or `<ol>` parent elements.',
failureTitle: 'List items (`<li>`) are not contained within `<ul>`, ' +
'`<ol>` or `<menu>` parent elements.',
/** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'Screen readers require list items (`<li>`) to be contained within a ' +
'parent `<ul>` or `<ol>` to be announced properly. ' +
'parent `<ul>`, `<ol>` or `<menu>` to be announced properly. ' +
'[Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).',
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2742,8 +2742,8 @@
},
"listitem": {
"id": "listitem",
"title": "List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements",
"description": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>` or `<ol>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).",
"title": "List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements",
"description": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>`, `<ol>` or `<menu>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).",
"score": 1,
"scoreDisplayMode": "binary",
"details": {
Expand Down Expand Up @@ -11726,8 +11726,8 @@
},
"listitem": {
"id": "listitem",
"title": "List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements",
"description": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>` or `<ol>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).",
"title": "List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements",
"description": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>`, `<ol>` or `<menu>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).",
"score": 1,
"scoreDisplayMode": "binary",
"details": {
Expand Down Expand Up @@ -16757,8 +16757,8 @@
},
"listitem": {
"id": "listitem",
"title": "List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements",
"description": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>` or `<ol>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).",
"title": "List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements",
"description": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>`, `<ol>` or `<menu>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).",
"score": 1,
"scoreDisplayMode": "binary",
"details": {
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -4049,8 +4049,8 @@
},
"listitem": {
"id": "listitem",
"title": "List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements",
"description": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>` or `<ol>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).",
"title": "List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements",
"description": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>`, `<ol>` or `<menu>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).",
"score": null,
"scoreDisplayMode": "notApplicable"
},
Expand Down
6 changes: 3 additions & 3 deletions shared/localization/locales/en-US.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions shared/localization/locales/en-XL.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Auditing: `<input type="image">` elements have `[alt]` text
Auditing: Form elements have associated labels
Auditing: Links have a discernible name
Auditing: Lists contain only `<li>` elements and script supporting elements (`<script>` and `<template>`).
Auditing: List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements
Auditing: List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements
Auditing: The document does not use `<meta http-equiv="refresh">`
Auditing: `[user-scalable="no"]` is not used in the `<meta name="viewport">` element and the `[maximum-scale]` attribute is not less than 5.
Auditing: `<object>` elements have alternate text
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ Auditing: `<input type="image">` elements have `[alt]` text
Auditing: Form elements have associated labels
Auditing: Links have a discernible name
Auditing: Lists contain only `<li>` elements and script supporting elements (`<script>` and `<template>`).
Auditing: List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements
Auditing: List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements
Auditing: The document does not use `<meta http-equiv="refresh">`
Auditing: `[user-scalable="no"]` is not used in the `<meta name="viewport">` element and the `[maximum-scale]` attribute is not less than 5.
Auditing: `<object>` elements have alternate text
Expand Down