-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(listitem): mention li can be contained by a menu #13927
Conversation
Axe-core has been updated to allow listitems to exist inside menu elements, in accordance with the HTML spec. So, this text should be updated since axe-core has been updated to 4.4.x (GoogleChrome@37a1ceb)
You will need to run |
Ah, got it, missed that before! |
This is our fault, but we have a newly extra step to deal with too: @adamraine wdyt of having |
At least the error said it, too, haha, done! :D |
SGTM |
I see some tests are failing but this is a little over my head, do I need to fix something on my end? |
You won't believe it but... we also have to run |
Haha I found that command in one of the failed test messages, but when I ran it nothing changed so I was already confused. Thanks for picking it up :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Axe-core has been updated to allow listitems to exist inside menu elements, in accordance with the HTML spec. So, this text should be updated since axe-core has been updated to 4.4.x (37a1ceb)
Related to GoogleChrome/web.dev#7802 and GoogleChrome/web.dev#7803 in the web.dev repo.
Menu spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-menu-element
Menu on MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu
Related Issues/PRs
#13926