Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: add buttons to .lh-buttons flex container #12516

Merged
merged 6 commits into from
May 19, 2021
+13 −7
Merged

report: add buttons to .lh-buttons flex container #12516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcddff9
wip
connorjclark May 18, 2021
5d94d3e
update
connorjclark May 18, 2021
193536f
pr
connorjclark May 19, 2021
21d7f86
update
connorjclark May 19, 2021
3f1e77e
report: add buttons to .lh-buttons flex container
connorjclark May 19, 2021
084ff18
Merge remote-tracking branch 'origin/master' into lhbuttonsflex
connorjclark May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lighthouse-core/report/html/renderer/report-ui-features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,17 +188,19 @@ class ReportUIFeatures {
// Not supported without metrics group.
if (!metricsEl) return;

let buttonsEl = metricsEl.querySelector('.lh-buttons');
if (!buttonsEl) buttonsEl = this._dom.createChildOf(metricsEl, 'div', 'lh-buttons');

const classes = [
'lh-button',
];
if (opts.icon) {
classes.push('report-icon');
classes.push(`report-icon--${opts.icon}`);
}
const buttonEl = this._dom.createChildOf(metricsEl, 'button', classes.join(' '));
buttonEl.addEventListener('click', opts.onClick);
const buttonEl = this._dom.createChildOf(buttonsEl, 'button', classes.join(' '));
buttonEl.textContent = opts.text;
metricsEl.append(buttonEl);
buttonEl.addEventListener('click', opts.onClick);
return buttonEl;
}

Expand Down
12 changes: 8 additions & 4 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.