Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: add buttons to .lh-buttons flex container #12516

Merged
merged 6 commits into from
May 19, 2021
Merged

report: add buttons to .lh-buttons flex container #12516

merged 6 commits into from
May 19, 2021

Conversation

connorjclark
Copy link
Collaborator

image

also moved the opacity to just the icon element

@connorjclark connorjclark requested a review from a team as a code owner May 19, 2021 20:13
@connorjclark connorjclark requested review from adamraine and removed request for a team May 19, 2021 20:13
@google-cla google-cla bot added the cla: yes label May 19, 2021
@connorjclark
Copy link
Collaborator Author

oh, this also requires deleting this line in devtools:

container.insertBefore(timelineButton, disclaimerEl.nextSibling);

@connorjclark connorjclark merged commit 83d0c96 into master May 19, 2021
@connorjclark connorjclark deleted the lhbuttonsflex branch May 19, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @adamraine @devtools-bot