Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add source-maps gatherer to default config #10990

Merged
merged 8 commits into from
Jun 24, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1349,6 +1349,9 @@ Object {
Object {
"path": "inspector-issues",
},
Object {
"path": "source-maps",
},
],
"loadFailureMode": "fatal",
"networkQuietThresholdMs": 1000,
Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/config/default-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ const defaultConfig = {
'accessibility',
'trace-elements',
'inspector-issues',
'source-maps',
],
},
{
Expand Down
6 changes: 0 additions & 6 deletions lighthouse-core/config/experimental-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@
/** @type {LH.Config.Json} */
const config = {
extends: 'lighthouse:default',
passes: [{
passName: 'defaultPass',
gatherers: [
'source-maps',
],
}],
audits: [
'byte-efficiency/duplicated-javascript',
'legacy-javascript',
Expand Down
13 changes: 3 additions & 10 deletions lighthouse-core/test/config/config-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ describe('Config', () => {
'ViewportDimensions', // from gatherer
],
__internalOptionalArtifacts: [
'SourceMaps', // Not in the config.
'SourceMapsBlah', // Not in the config.
connorjclark marked this conversation as resolved.
Show resolved Hide resolved
],
};
}
Expand Down Expand Up @@ -230,7 +230,7 @@ describe('Config', () => {
'ViewportDimensions', // from gatherer
],
__internalOptionalArtifacts: [
'SourceMaps', // Not in the config.
'SourceMapsBlah', // Not in the config.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is exactly the same test as on line 151?

somehow these got repeated three times :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow these got repeated three times :)

does not throw when an audit requests an optional artifact with no gatherer supplying it is still in there one extra time and should keep optional artifacts in gatherers after filter test is repeated three times :)

],
};
}
Expand Down Expand Up @@ -271,13 +271,6 @@ describe('Config', () => {

const config = new Config({
extends: 'lighthouse:default',
// TODO(cjamcl): remove when source-maps is in default config.
passes: [{
passName: 'defaultPass',
gatherers: [
'source-maps',
],
}],
audits: [ButWillStillTakeYourCrap],
}, {
// Trigger filtering logic.
Expand All @@ -300,7 +293,7 @@ describe('Config', () => {
'ViewportDimensions', // from gatherer
],
__internalOptionalArtifacts: [
'SourceMaps', // Not in the config.
'SourceMapsBlah', // Not in the config.
],
};
}
Expand Down