core: add source-maps gatherer to default config

[connorjclark]

No description provided.

[brendankenny]

🎉 🎉

unused-javascript should move 'SourceMaps' out of __internalOptionalArtifacts too?

And is there a simple source map we could add to dbw-tester to not change it too much but also get them to start showing up in sample_v2.json?

[brendankenny]

looks like this is exactly the same test as on line 151?

somehow these got repeated three times :)

[brendankenny]

somehow these got repeated three times :)

does not throw when an audit requests an optional artifact with no gatherer supplying it is still in there one extra time and should keep optional artifacts in gatherers after filter test is repeated three times :)

[connorjclark]

And is there a simple source map we could add to dbw-tester to not change it too much but also get them to start showing up in sample_v2.json?

We have plenty of other end-to-end tests for source maps (smoke, legacy-js), so this isn't too critical. It seems like the entire sample artifacts could use a reset, seems better than patching as we go.

[brendankenny]

And is there a simple source map we could add to dbw-tester to not change it too much but also get them to start showing up in sample_v2.json?

We have plenty of other end-to-end tests for source maps (smoke, legacy-js), so this isn't too critical. It seems like the entire sample artifacts could use a reset, seems better than patching as we go.

I was suggesting actually adding them to dbw-tester, not an artifacts patch.

Anyways, it's not critical, it was just a suggestion based on #10978 (comment), which, let's just check who left thumbs up reactions on that comment... :P

[brendankenny]

nice to delete the repeated tests, otherwise LGTM!