Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add readme for build/ #10004

Merged
merged 2 commits into from
Dec 7, 2019
Merged

docs: add readme for build/ #10004

merged 2 commits into from
Dec 7, 2019

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Nov 21, 2019 •
edited by connorjclark
Loading

@connorjclark
Copy link
Collaborator

yup

patrickhulce
patrickhulce approved these changes Nov 22, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great writeup connor :)

build/readme.md Outdated Show resolved Hide resolved
build/readme.md Outdated Show resolved Hide resolved
build/readme.md Outdated Show resolved Hide resolved
build/readme.md Outdated Show resolved Hide resolved
build/readme.md Outdated Show resolved Hide resolved
build/readme.md Outdated Show resolved Hide resolved
@paulirish paulirish merged commit c4ab6a0 into master Dec 7, 2019
@paulirish paulirish deleted the buildreadme branch December 7, 2019 00:53
connorjclark added a commit that referenced this pull request Dec 9, 2019
@connorjclark
Squashed commit of the following:
e22ad8d 
commit 3848221
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 14:38:40 2019 -0800

    tests

commit d73c056
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 13:32:41 2019 -0800

    rm row.multi

commit 2b9babb
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 12:31:13 2019 -0800

    initial

commit c4ab6a0
Author: Paul Irish <[email protected]>
Date:   Fri Dec 6 16:53:42 2019 -0800

    docs: add readme for build/ (#10004)
connorjclark added a commit that referenced this pull request Dec 10, 2019
@connorjclark
Squashed commit of the following:
da0aa63 
commit 95ab723
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 19:39:02 2019 -0800

    dry _getCanonicalizedHeadingsFromTable

commit dc75cbf
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 15:19:31 2019 -0800

    do not need _ yet

commit 8a5f433
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 15:10:46 2019 -0800

    fix types

commit 774de08
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 14:50:58 2019 -0800

    delete code not needed yet

commit 3848221
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 14:38:40 2019 -0800

    tests

commit d73c056
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 13:32:41 2019 -0800

    rm row.multi

commit 2b9babb
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 12:31:13 2019 -0800

    initial

commit c4ab6a0
Author: Paul Irish <[email protected]>
Date:   Fri Dec 6 16:53:42 2019 -0800

    docs: add readme for build/ (#10004)
connorjclark added a commit that referenced this pull request Dec 10, 2019
@connorjclark
Squashed commit of the following:
18794ae 
commit 652059e
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 22:34:28 2019 -0800

    fix null mapping bug

commit 2ed3b7b
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 19:20:27 2019 -0800

    lint

commit 65cc13c
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 19:08:10 2019 -0800

    test for unused bundle

commit 7886f5e
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 15:21:30 2019 -0800

    do not need _ yet

commit 4a62a54
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 15:17:50 2019 -0800

    initial

commit c4ab6a0
Author: Paul Irish <[email protected]>
Date:   Fri Dec 6 16:53:42 2019 -0800

    docs: add readme for build/ (#10004)
connorjclark added a commit that referenced this pull request Dec 13, 2019
@connorjclark
Squashed commit of the following:
5c00796 
commit 0ee5d5a
Author: Connor Clark <[email protected]>
Date:   Thu Dec 12 13:57:45 2019 -0800

    move type check

commit 50eb275
Author: Connor Clark <[email protected]>
Date:   Thu Dec 12 13:55:09 2019 -0800

    subRows

commit 95ab723
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 19:39:02 2019 -0800

    dry _getCanonicalizedHeadingsFromTable

commit dc75cbf
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 15:19:31 2019 -0800

    do not need _ yet

commit 8a5f433
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 15:10:46 2019 -0800

    fix types

commit 774de08
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 14:50:58 2019 -0800

    delete code not needed yet

commit 3848221
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 14:38:40 2019 -0800

    tests

commit d73c056
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 13:32:41 2019 -0800

    rm row.multi

commit 2b9babb
Author: Connor Clark <[email protected]>
Date:   Mon Dec 9 12:31:13 2019 -0800

    initial

commit c4ab6a0
Author: Paul Irish <[email protected]>
Date:   Fri Dec 6 16:53:42 2019 -0800

    docs: add readme for build/ (#10004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
cla: yes land-when-ci-is-green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulirish @connorjclark @patrickhulce @googlebot