Skip to content

Commit

Permalink
do not need _ yet
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark committed Dec 9, 2019
1 parent 4a62a54 commit 7886f5e
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions lighthouse-core/report/html/renderer/details-renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -370,16 +370,10 @@ class DetailsRenderer {
for (const heading of headings) {
const valueFragment = this._dom.createFragment();

if (heading.key === '_') {
const emptyElement = this._dom.createElement('div');
emptyElement.innerHTML = ' ';
valueFragment.appendChild(emptyElement);
} else {
const value = row[heading.key];
const valueElement =
value !== undefined && !Array.isArray(value) && this._renderTableValue(value, heading);
if (valueElement) valueFragment.appendChild(valueElement);
}
const value = row[heading.key];
const valueElement =
value !== undefined && !Array.isArray(value) && this._renderTableValue(value, heading);
if (valueElement) valueFragment.appendChild(valueElement);

if (heading.multi) {
const multiHeading = {
Expand Down

0 comments on commit 7886f5e

Please sign in to comment.