Skip to content

Commit

Permalink
tests: run every smoke test (except forms) for bundle (#11493)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark authored Oct 2, 2020
1 parent 925cb1d commit 6a75241
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 4 deletions.
22 changes: 20 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ jobs:
- run: sudo apt-get install xvfb
- name: yarn test-clients
run: xvfb-run --auto-servernum yarn test-clients
- name: yarn test-bundle
run: xvfb-run --auto-servernum yarn test-bundle
- name: yarn test-docs
run: xvfb-run --auto-servernum yarn test-docs
- name: yarn test-viewer
Expand Down Expand Up @@ -172,3 +170,23 @@ jobs:

- name: Run smoke tests
run: yarn smoke --debug -j=1 --retries=2 dbw oopif offline lantern metrics

smoke-bundle:
runs-on: ubuntu-latest
name: smoke_bundle

steps:
- name: git clone
uses: actions/checkout@v2

- name: Use Node.js 10.x
uses: actions/setup-node@v1
with:
node-version: 10.x

- run: yarn --frozen-lockfile
- run: yarn build-devtools

- run: sudo apt-get install xvfb
- name: yarn test-bundle
run: xvfb-run --auto-servernum yarn test-bundle
4 changes: 3 additions & 1 deletion lighthouse-cli/test/smokehouse/lighthouse-runners/bundle.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ const lighthouse = global.runBundledLighthouse;
*/
async function runLighthouse(url, configJson, testRunnerOptions = {}) {
// Launch and connect to Chrome.
const launchedChrome = await ChromeLauncher.launch();
const launchedChrome = await ChromeLauncher.launch({
chromeFlags: ['--enable-features=AutofillShowTypePredictions'],
});
const port = launchedChrome.port;
const connection = new ChromeProtocol(port);

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"debug": "node --inspect-brk ./lighthouse-cli/index.js",
"start": "node ./lighthouse-cli/index.js",
"test": "yarn diff:sample-json && yarn lint --quiet && yarn unit && yarn type-check",
"test-bundle": "yarn smoke --runner bundle -j=1 --retries=2 dbw byte a11y",
"test-bundle": "yarn smoke --runner bundle -j=1 --retries=2 --invert-match forms",
"test-clients": "jest \"clients/\"",
"test-viewer": "yarn unit-viewer && jest lighthouse-viewer/test/viewer-test-pptr.js",
"test-lantern": "bash lighthouse-core/scripts/test-lantern.sh",
Expand Down

0 comments on commit 6a75241

Please sign in to comment.