core: prevent attribute truncation side-effects (#11503)

GoogleChrome · Oct 1, 2020 · 925cb1d · 925cb1d
1 parent ae69bd6
commit 925cb1d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lighthouse-core/lib/page-functions.js b/lighthouse-core/lib/page-functions.js
@@ -125,6 +125,10 @@ function getOuterHTMLSnippet(element, ignoreAttrs = [], snippetCharacterLimit =
     }
 
     const clone = element.cloneNode();
+    // Prevent any potential side-effects by appending to a template element.
+    // See https://github.com/GoogleChrome/lighthouse/issues/11465
+    const template = element.ownerDocument.createElement('template');
+    template.content.append(clone);
     ignoreAttrs.concat(autoFillIgnoreAttrs).forEach(attribute =>{
       clone.removeAttribute(attribute);
     });