core(redirects): score only on wasted ms (#15401)

GoogleChrome · Aug 23, 2023 · 614170f · 614170f
1 parent cd09b63
commit 614170f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/cli/test/smokehouse/test-definitions/redirects-single-server.js b/cli/test/smokehouse/test-definitions/redirects-single-server.js
@@ -45,7 +45,7 @@ const expectations = {
         numericValue: '>=2000',
       },
       'redirects': {
-        score: 1,
+        score: 0.29,
         numericValue: '>=2000',
         details: {
           items: [

diff --git a/core/audits/redirects.js b/core/audits/redirects.js
@@ -144,10 +144,7 @@ class Redirects extends Audit {
       {overallSavingsMs: totalWastedMs});
 
     return {
-      // We award a passing grade if you only have 1 redirect
-      // TODO(phulce): reconsider if cases like the example in https://github.com/GoogleChrome/lighthouse/issues/8984
-      // should fail this audit.
-      score: documentRequests.length <= 2 ? 1 : ByteEfficiencyAudit.scoreForWastedMs(totalWastedMs),
+      score: ByteEfficiencyAudit.scoreForWastedMs(totalWastedMs),
       numericValue: totalWastedMs,
       numericUnit: 'millisecond',
       displayValue: totalWastedMs ?

diff --git a/core/test/audits/redirects-test.js b/core/test/audits/redirects-test.js
@@ -218,14 +218,12 @@ describe('Performance: Redirects audit', () => {
     });
   });
 
-  it('passes when one redirect detected', () => {
+  it('fails when 1 redirect detected', () => {
     const artifacts = mockArtifacts(SUCCESS_ONE_REDIRECT, 'https://www.lisairish.com/');
     const context = {settings: {}, computedCache: new Map()};
     return RedirectsAudit.audit(artifacts, context).then(output => {
-      // If === 1 redirect, perfect score is expected, regardless of latency
-      // We will still generate a table and show wasted time
       expect(output.details.items).toHaveLength(2);
-      expect(output.score).toEqual(1);
+      expect(output.score).toEqual(0.48);
       expect(output.numericValue).toMatchInlineSnapshot(`1000`);
       expect(output.metricSavings).toEqual({LCP: 1000, FCP: 1000});
     });