core(viewport-meta): include initial-scale value condition (#15394)

GoogleChrome · Aug 21, 2023 · cd09b63 · cd09b63
1 parent 958177d
commit cd09b63
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/core/computed/viewport-meta.js b/core/computed/viewport-meta.js
@@ -35,7 +35,17 @@ class ViewportMeta {
     }
 
     const viewportProps = parsedProps.validProperties;
-    const isMobileOptimized = Boolean(viewportProps.width || viewportProps['initial-scale']);
+    const initialScale = Number(viewportProps['initial-scale']);
+
+    if (!isNaN(initialScale) && initialScale < 1) {
+      return {
+        hasViewportTag: true,
+        isMobileOptimized: false,
+        parserWarnings: warnings,
+      };
+    }
+
+    const isMobileOptimized = Boolean(viewportProps.width || initialScale);
 
     return {
       hasViewportTag: true,

diff --git a/core/test/computed/viewport-meta-test.js b/core/test/computed/viewport-meta-test.js
@@ -52,6 +52,14 @@ describe('ViewportMeta computed artifact', () => {
     assert.equal(parserWarnings[1], 'Invalid values found: {"initial-scale":"microscopic"}');
   });
 
+  // eslint-disable-next-line max-len
+  it('is not mobile optimized when a viewport contains an initial-scale value lower than 1', async () => {
+    const viewport = 'width=device-width, initial-scale=0.9';
+    const {isMobileOptimized} =
+      await ViewportMeta.compute_(makeMetaElements(viewport));
+    assert.equal(isMobileOptimized, false);
+  });
+
   it('is mobile optimized when a valid viewport is provided', async () => {
     const viewports = [
       'width=device-width, initial-scale=1, minimum-scale=1, maximum-scale=1',