feat(cli): upgrade to Lighthouse 6.4.1 #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simplest step (bumping package version) is done. Will look at adding the new fixtures, etc shortly... keeping the PR draft until ready for review. |
csabapalfi
force-pushed
the
lighthouse-6.4.1
branch
8 times, most recently
from
481ec75
to
e91229f
Compare
BREAKING CHANGE: new audits
csabapalfi
force-pushed
the
lighthouse-6.4.1
branch
from
e91229f
to
cf6376c
Compare
|
@patrickhulce This PR is now ready for review. Please let me know what you think! 😊 |
patrickhulce
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
thank you so much @csabapalfi this is fantastic! an enormous help!! 🙏 😃 🎉
I'm going to go ahead and merge this right after I ship one more non-breaking version with the current fixes on master 👍
| @@ -37,6 +37,11 @@ describe('Lighthouse CI CLI', () => { | |||
| let projectAdminToken; | |||
| let urlToCollect; | |||
|
|
|||
| beforeAll(async () => { | |||
denkrasnov
pushed a commit
to Travix-International/lighthouse-ci
that referenced
this pull request
Oct 29, 2020
BREAKING CHANGE: Lighthouse 6.4.1 with new audits in assertion presets and affected scores.
This was referenced Dec 19, 2020
This was referenced Jan 28, 2021
This was referenced Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: new audits
fixes #443