Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse 6.3 #443

Closed
alex-misch opened this issue Sep 14, 2020 · 4 comments · Fixed by #470
Closed

Lighthouse 6.3 #443

alex-misch opened this issue Sep 14, 2020 · 4 comments · Fixed by #470
Labels
enhancement New feature or request P2

Comments

@alex-misch
Copy link

Hi! Google's "PageSpeed Insights" is updated to version 6.3 on the 27th of august. It will be nice to get an update of "lhci" too.

@patrickhulce
Copy link
Collaborator

Every minor update of Lighthouse that introduces new audits becomes a breaking change in LHCI (see version policy). LHCI won't be as quick to update to avoid excessive churn, but yes we will eventually update to a new LH version.

@patrickhulce patrickhulce added enhancement New feature or request P2 labels Sep 14, 2020
@csabapalfi
Copy link
Contributor

csabapalfi commented Oct 12, 2020

@patrickhulce Is there any way I can help out with this? (e.g. PR 😄)

I can't enable lhci on a project while we're waiting for GoogleChrome/lighthouse#11503 in 6.4.1.

@patrickhulce
Copy link
Collaborator

Sure @csabapalfi a PR would be accepted for 6.4.1 but fair warning it's not a trivial amount of work :)

You can use #416 as a template.

Roughly...

  • Bump the lighthouse version in package.json of both cli and utils
  • Checkin two new LHR runs of coursehero to fixtures (just a useful site that has source maps to exercise those audits)
  • Add the new fixture LHRs to all of our renderer tests
  • Update all the expectations

@csabapalfi
Copy link
Contributor

Thanks for the quick reply! I'll let you know if I can start on this (might be later this week - at the earliest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants