Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swerve angle offset feature #59

Merged
merged 17 commits into from
Aug 28, 2024
Merged

Conversation

DanPeled
Copy link
Contributor

@DanPeled DanPeled commented Jul 2, 2024

Added an angle offset feature for the YAGSL swerve widget due to different ways libraries wirk and where the robot points at 0deg

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.50%. Comparing base (d338a6e) to head (41fea0d).
Report is 1 commits behind head on main.

Files Patch % Lines
...ets/nt_widgets/multi-topic/yagsl_swerve_drive.dart 33.33% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   63.58%   63.50%   -0.08%     
==========================================
  Files          75       75              
  Lines        7892     7908      +16     
==========================================
+ Hits         5018     5022       +4     
- Misses       2874     2886      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 force-pushed the main branch 3 times, most recently from 28141b6 to 247ea07 Compare August 18, 2024 05:43
…d automatically converted to rad if needed), replaced double.parse to double.tryParse
@DanPeled DanPeled requested a review from Gold872 August 19, 2024 17:41
Copy link
Owner

@Gold872 Gold872 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gold872 Gold872 merged commit ba22ca9 into Gold872:main Aug 28, 2024
5 checks passed
@DanPeled DanPeled deleted the swerve_angle_offset branch August 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants