Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPILib build #112

Merged
merged 8 commits into from
Oct 16, 2024
Merged

Add WPILib build #112

merged 8 commits into from
Oct 16, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Oct 15, 2024

Runs a separate build workflow for a version of Elastic with the WPILib icons and separate title

The WPILib build does not check for updates from the GitHub repository as it is installed through the WPILib installer

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base (d719f43) to head (5802b42).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   66.15%   66.19%   +0.03%     
==========================================
  Files          77       78       +1     
  Lines        8014     8022       +8     
==========================================
+ Hits         5302     5310       +8     
  Misses       2712     2712              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold856
Copy link
Contributor

Gold856 commented Oct 15, 2024

In my opinion, Elastic can keep its own logo. AdvantageScope will be using its own logo for 2025.

@Gold872
Copy link
Owner Author

Gold872 commented Oct 15, 2024

For the executable icon itself, I want to use the WPILib logo so that way the 2 different distributions don't get mixed up

@Gold872 Gold872 merged commit c0b589b into main Oct 16, 2024
8 checks passed
@Gold872 Gold872 deleted the wpilib-build branch October 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants