Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed climbing to one-handed dominance #235

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request implements feature #210 by making climbing use a single dominant hand.

…y grabbed a climbable.

Climbing no-longer uses the average of both hands, which prevents some "cheat" options.
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, I'd have to play with it a bit in game, I'm wondering how well things work if you grab with your left hand, now grab with your right, pull yourself up with your right and then let go with your right.

The dominant hand now changes back to your left hand, but it is now no-where near where you originally grabbed the wall. It may look weird if you continue to climb with your left hand when its new starting location is somewhere floating in space...

Or do we ungrab the left hand in this case when it moves off far enough?

@Malcolmnixon
Copy link
Collaborator Author

If the secondary hand moves more than 1 meter from its grab-point (either because the primary hand has moved the player, or the player moves their secondary hand) then the secondary hand grab is released. If the player then releases their primary hand then the player will fall.

@Malcolmnixon Malcolmnixon merged commit dde8747 into GodotVR:master Oct 30, 2022
@Malcolmnixon Malcolmnixon deleted the climb-single-hand-control branch October 30, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants