Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movement_climb should be one-handed #210

Closed
goatchurchprime opened this issue Oct 14, 2022 · 5 comments
Closed

movement_climb should be one-handed #210

goatchurchprime opened this issue Oct 14, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@goatchurchprime
Copy link
Contributor

The two handed average offset is something I've never seen in any game, partly because it will always jerk when the second hand is applied or released. Normally the second hand takes control from the first hand.

Also it would be feel more positive if the hand/arm had to be within the surface rather than an invisible distance from away.

@Malcolmnixon
Copy link
Collaborator

We could change it to use the most recent grab possibly. The averaging solves some corner case - for example with single-handed grabbing what happens when:

  1. The player grabs a wall with the left hand.
  2. The player grabs the wall with the right hand and pulls themselves up a foot.
  3. The player let's go with their right hand, but is still holding with the left.

@BastiaanOlij
Copy link
Member

It's also a matter that we don't anchor the hands, they stay attached to the controller.

Many climbing games do have two handed functionality but the moment a hand grabs something, it is no longer attached to the controller, it is now attached to the place that is grabbed, and is let go automatically when the hand moves too far away.

That said, @goatchurchprime example is also true, where the last hand that grabs determined the movement. Let go with that hand and the first hand takes over again. Still even in that situation the hands once grabbing the wall get anchored to that place on the wall instead of following controller movement.

@Malcolmnixon
Copy link
Collaborator

I'm reminded of a Population-one bug where a player could hold on to a wall, then run half way across the map, then I believe if they released the grip they would teleport back to the wall.

We almost certainly have a similar bug in our current implementation. If a player grabs a stationary wall with the left hand, and a climbable moving platform with their right, then they would almost certainly be carried along at the average/center of those two positions.

One-handed with "snap the grab" if too far would solve that, although as you say we want to solve the hand decoupling at the same time.

@Malcolmnixon Malcolmnixon added this to the 3.1.0 milestone Oct 21, 2022
@BastiaanOlij
Copy link
Member

I still need to play Population One...

@Malcolmnixon
Copy link
Collaborator

@goatchurchprime could you confirm this climbing behavior works as desired, and if so close the issue.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants