Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified hand meshes to be pre-scaled so the scenes can be 1:1 scaled #159

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request modifies the scales on the following hand meshes:

  • LeftHand.blend
  • LeftHand.glb
  • RightHand.glb (not requred, as RightHand.tscn uses LeftHand.glb flipped in the X axis)

This simply applied the existing 0.068 scale present in LeftHand.blend (Set in the object transform, but not applied); and then applied another 0.5 scale present in the LeftHand.tscn and RightHand.tscn scenes. The scales were then set to 1:1 in the scenes.

The result is that the "LeftHand\LeftHand" node which used to have a 0.5, 0.5, 0.5 scale is now 1,1,1:
image

Additionally the "LeftHand\LeftHand\Armature_Left" node which used to have a 0.068, 0.068, 0.068 scale is also 1,1,1:
image

Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we need to be mindful of in the future. It is much better to have assets imported at their correct scales instead of applying scales in the engine

@BastiaanOlij BastiaanOlij merged commit bd3d92e into GodotVR:master Jul 15, 2022
@BastiaanOlij BastiaanOlij added this to the 2.5.0 milestone Jul 15, 2022
@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Jul 15, 2022
@Malcolmnixon Malcolmnixon deleted the hand-mesh-prescale branch July 15, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants