Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed enable/disable rules for movement providers #140

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

This fixes issue #139 where movement providers were inappropriately invoked. Now the movement provider is invoked if either of the following is true:

  • The movement provider is 'active'. An active movement provider is always invoked, even if it's to let the provider deactivate and send finished events.
  • The movement provider is 'enabled' and no higher priority movement provider has pre-empted control with an exclusive movement.

Fixed enable/disable rules for movement providers
@BastiaanOlij BastiaanOlij merged commit c165568 into GodotVR:master Jun 5, 2022
@BastiaanOlij BastiaanOlij added this to the 2.4.1 milestone Jun 5, 2022
@BastiaanOlij BastiaanOlij added the bug Something isn't working label Jun 5, 2022
@Malcolmnixon Malcolmnixon deleted the enabled-movement-fix branch June 12, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants