Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Enabled = false not deactivating movement providers in XRTools 2.4 #139

Closed
teddybear082 opened this issue May 30, 2022 · 2 comments
Closed

Comments

@teddybear082
Copy link
Contributor

Steps to reproduce:

Use Master OpenXR asset
Use XR-Tools latest release 2.4
Add direct movement nodes as children of left and right controllers
Check the box to make enabled = false in one of the direct movement nodes
Start scene
Regardless of the enabled checkbox being false on one of the direct movement nodes, both joysticks will still create direct movement

Also impacts (at minimum): Turn function, jump function

I'm wondering if the addition of the "is_active" property somehow undid the ability to disable movement providers by unchecking the enabled box in the editor? Note, using [function].enabled = false in code also fails to disable these movement providers, so it isn't just an editor issue.

Confirmed that disabling providers in editor or through code worked fine in 2.3.

Should we have a line in these providers for "if enabled = false: return"? Or is it more complicated than that with the new "is_active" setting?

@Malcolmnixon
Copy link
Collaborator

@teddybear082 could you verify this change works with your project and close the issue if it's good for you?

@teddybear082
Copy link
Contributor Author

Yes this works thank you! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants