fix: update donation success QF Toast

[Meriem-BM]

Related to #4247

Summary by CodeRabbit

• Bug Fixes

  • Updated internal link and button label in the QFToast component to correctly reflect eligibility routing and messaging.
  • Improved text formatting in the QFToast description for better readability.

• Refactor

  • Consolidated conditions for showing the QFToast in the SuccessView component to enhance code readability and maintainability.
  • Changed currentRound assignment in usePassport to use activeQFRound for more accurate data handling.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 17, 2024 7:35pm

[coderabbitai]

Walkthrough

The recent updates primarily enhance the QFToast component and its integration with the SuccessView component. The IconPassport24 import was removed, and the routing logic was refined to improve user navigation based on eligibility. Styling improvements were made to the Description component, and a new variable showQFToast centralizes the logic for displaying the toast in SuccessView. Additionally, the usePassport hook was updated to use a more accurate round property.

Changes

File Path	Change Summary
src/components/views/donate/QFToast.tsx	Removed IconPassport24 import, updated href and button label logic, added white-space: pre-line.
src/components/views/donate/SuccessView.tsx	Introduced showQFToast variable to centralize the logic for rendering the QFToast component.
src/hooks/usePassport.ts	Updated property assignment from info.currentRound to activeQFRound within the usePassport hook.

Poem

In the code, a change does bloom,
Routes aligned, with less room.
QFToast now clear and bright,
Shows the path, the way is light.
With whispers of the round so neat,
Our journey in the code, complete.
🌟✨🐇

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ae4659e and 36881f0.

Files selected for processing (3)

• src/components/views/donate/QFToast.tsx (5 hunks)
• src/components/views/donate/SuccessView.tsx (2 hunks)
• src/hooks/usePassport.ts (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/components/views/donate/QFToast.tsx

Additional comments not posted (4)

src/components/views/donate/SuccessView.tsx (2)

151-151: Refactoring to improve readability and maintainability approved.

The refactoring to use a single variable showQFToast for determining the display of the QFToast component enhances code readability and maintainability.

---

92-102: Verify the consolidated condition for displaying the QFToast.

The showQFToast variable consolidates multiple conditions to determine if the QFToast should be displayed. Ensure that this consolidation accurately reflects all the intended conditions without any logical errors.

Verification successful

---

Verified the consolidated condition for displaying the QFToast.

The showQFToast variable correctly consolidates multiple conditions to determine if the QFToast should be displayed and is used appropriately within the SuccessView component.

• Location: src/components/views/donate/SuccessView.tsx

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all conditions for showing QFToast are correctly implemented.

# Test: Search for the usage of `showQFToast` variable. Expect: Only occurances within the `SuccessView` component.
rg --type typescript -A 5 $'showQFToast'

Length of output: 74

---

Script:

#!/bin/bash
# Description: Verify that all conditions for showing QFToast are correctly implemented.

# Test: Search for the usage of `showQFToast` variable. Expect: Only occurrences within the `SuccessView` component.
rg --type ts -A 5 $'showQFToast'

Length of output: 911

src/hooks/usePassport.ts (2)

Line range hint 271-287: Refactoring to update the currentRound property approved.

The update of the currentRound property to activeQFRound in the usePassport hook is approved as it aligns with the new logic introduced in the PR.

Also applies to: 334-334

---

271-271: Verify the updated property assignment in usePassport.

The currentRound property has been updated to activeQFRound in multiple places within the usePassport hook. Ensure that this change is consistently implemented and does not introduce any logical errors.

Also applies to: 287-287, 334-334

Verification successful

---

Verified the updated property assignment in usePassport.

The currentRound property has been consistently updated to activeQFRound throughout the usePassport hook without introducing any logical errors.

• src/hooks/usePassport.ts: Multiple instances of currentRound being assigned to activeQFRound.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the `currentRound` property is consistently updated to `activeQFRound` across the `usePassport` hook.

# Test: Search for the usage of `currentRound` property. Expect: Only assignments to `activeQFRound`.
rg --type typescript -A 5 $'currentRound'

Length of output: 75

---

Script:

#!/bin/bash
# Description: Verify that the `currentRound` property is consistently updated to `activeQFRound` across the `usePassport` hook.

# Test: Search for the usage of `currentRound` property. Expect: Only assignments to `activeQFRound`.
rg --type ts -A 5 'currentRound'

Length of output: 17420

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

src/lib/constants/Routes.ts (1)

67-67: Numerous references to Passport found throughout the codebase.

The change from Passport to QFElegibility in the routes may not have been fully propagated. Please review and update the following files and lines to ensure consistency:

• src/services/passport.ts
• src/hooks/usePassport.ts
• src/helpers/passport.ts
• src/features/user/user.slice.ts
• src/components/PassportButton.tsx
• src/components/PassportBanner.tsx
• src/components/views/userProfile/common.sc.tsx
• src/components/views/userProfile/QFDonorEligibilityCard.tsx
• src/components/views/userProfile/PassportCard.tsx
• src/components/views/qfEligibility/QFEligibility.view.tsx
• src/components/views/passport/passport.view.tsx
• src/components/views/projects/ProjectsIndex.tsx
• src/components/views/project/ProjectIndex.tsx
• src/components/views/donate/DonateIndex.tsx
• src/components/views/donate/SuccessView.tsx
• src/components/views/donate/QFToast.tsx
• src/components/modals/PassportModal.tsx
• src/apollo/types/types.ts
• pages/passport.tsx
• src/apollo/gql/gqlQF.ts
• lang/t_es.json
• lang/t_ca.json
• lang/en.json
• lang/es.json
• lang/ca.json

Analysis chain

Approved change of route key from Passport to QFElegibility.

The change aligns with the PR objectives to update the donation success QF Toast. However, ensure all references to the old Passport route are updated throughout the codebase.

---

Let's correct the file type and rerun the search to ensure all references to the old Passport route are updated.

---

Let's perform a broader search to ensure all references to Passport have been updated in the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all references to the old `Passport` route are updated.

# Test: Search for the old route key in the codebase. Expect: No occurrences.
rg --type python 'Routes.Passport'

Length of output: 65

---

Script:

#!/bin/bash
# Description: Verify all references to the old `Passport` route are updated.

# Test: Search for the old route key in the codebase. Expect: No occurrences.
rg 'Routes.Passport'

Length of output: 20

---

Script:

#!/bin/bash
# Description: Verify all references to the old `Passport` route are updated.

# Test: Search for any references to `Passport` in the codebase. Expect: No occurrences.
rg 'Passport'

Length of output: 28045

[kkatusic]

LGTM ;)