-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User flow for implementing model-based detection system into QF rounds #4247
Comments
Thank @mosaeedi that's looking great! I just shared your comment w/ @CarlosQ96 as he's working on the backend API integration. One thought - I wonder if users will be confused if we name it "Quick identity check", since it's not really related to identity. Maybe we can name it "Quick on-chain activity check" or something similar? What do you think @laurenluz ? |
Hey @mosaeedi! This looks pretty good but tbh I think we can make it a lot more simplified for the user. Seeing all these parts "user verification" and having that separated from "qf eligibility" imo is not necessary because the user verification IS the eligibility, it's just the method by which they verify that changes. The advantage of the MBD system is that we can make thing a lot less complex for many users... so I would like the design to be a lot simpler as well. If you think it's ok, I would suggest removing the bottom box entirely and having the user see just one box basically... that changes in copy and appearance based on the following states. They would only see the gitcoin passport info (replacing the 1st box) if they do not pass the 1st check on the MBD. So the states would be: For initial copy, I'd suggest: Title for the page: QF Donor Eligibility Box copy, e.g. for case (2) wallet connected by not yet checked w/ MBD After the user passes, the label says "QF eligible". What do you think? Also could you link to the figma? |
Aside from that, can you also help to outline the banner copy & the donation success page copies for each of the different states? I think we will need to make adjustments to the logic and it would help to make this all clear for our devs. Also, thinking about this... should we keep all this verification information in the user profile? or do you think it would be better to make this a kind of replacement for the https://giveth.io/passport ? And then we direct users to that page through out existing QF flow? |
Take a look here -> Figma Link |
Here is the mini banner for the Projects list/view project page take a look here -> Figma Link |
And the last part! Success page Take a look here -> Figma Link |
@mosaeedi @koday1 let me know if the design is done so @Meriem-BM can start on it. |
@mosaeedi let's finalize the banners before we pass this to devs. |
also @koday1 @CarlosQ96 @Meriem-BM we have the made sure we don't merge this issue until the GIV-earth round is over. we can introduce a big change of eligibility like this mid-round, and it's ofc not going to be finalized tested and merged before tomorrow morning. |
Here is the QF banners! CC: @laurenluz @koday1 |
@mosaeedi The banners look good! @Meriem-BM please see the new banners above from Mo, and let me know if you have any questions. |
these banners need a few edits, please hold off @Meriem-BM @koday1 |
@mosaeedi I added some missing cases to the banners and make some edits to the copy here. Can you help to clean them up? Also, we need to have different donation success page info corresponding to the different cases as well. I'm talking about the copy here... We must have in figma the designs for the different cases... but I don't know where. @mosaeedi |
It has been fixed on feature branch https://giveth-dapps-v2-git-feat-mbdscoringissues-givethio.vercel.app
The new flow with "sign message" step is on the preview link : https://giveth-dapps-v2-git-feat-mbdscoringissues-givethio.vercel.app Screen.Recording.2024-07-27.at.12.50.30.AM.mov
-For an account that it isn't signed user, after connecting wallet the "sign message" is shown correctly Screen_Recording_2024-07-27_at_12.59.06_AM.mov-For this account that it isn't signed user, after connecting wallet the "sign message" is not shown |
Hey @maryjaf this only happens when a new user is connecting, the sign message add his data to Database, without it, the user data won't be found and that buggy behaviour appears, I believe we could have implemented this in better way to have one step, but that will introduce bugs. |
I think we should discuss this with the team, if we should only release QF related changes. cc: @jainkrati, @MohammadPCh |
Can we just remove any mention of connect wallet & sign message for the user? so they just follow the normal slow having to sign in like usual? I mentioned this here above, but I think it might have been misinterpreted...
I meant that we should just put the copy "Sign in with your wallet to verify your QF eligibility".. with absolutely no button there/clickable part in the banner... so no extra clickable text that says "sign in" or "sign message" or "connect wallet" The user should only get to click things after they have done their normal sign in flow. with the pink button in the top (like usual). If there are still bugs, can we just simplify to this? |
@laurenluz that won't work either, because by clicking on that pink sign in button the new user will still have to sign message, to be registered on Database. The pink sign in button only connects wallet as well. |
@Meriem-BM why is the sign message about gitcoin passport though? I would assume it should be about connecting to giveth |
this is still super buggy for me. When I connect my wallet from the banner... I get the metamask connect... but then nothign happens, even when I refresh. This issue doesn't happen if I connect & sign in from the pink button. Screen.Recording.2024-07-29.at.1.34.07.PM.mov |
It's weird, it works fine for me,I've checked multiple times with different accounts |
Weird, I don't know why did it happen |
Hey @maryjaf the connect wallet clickable link is removed. cc: @laurenluz |
Okay so all above should be done before user connect his wallet, unlike the old flow, will update it. |
Screen.Recording.2024-07-29.at.7.36.40.PM.mov |
@Meriem-BM can you investigate? that's super weird behaviour |
I've checked this new flow with some new and old users for most of them it works as expected Screen.Recording.2024-07-29.at.8.30.05.PM.mov
-by tapping on "check eligibility" nothing happens and then the "recheck eligibility " button is shown Screen.Recording.2024-07-29.at.8.24.57.PM.mov |
@Meriem-BM just checking - any update here? |
I've seen this problem one time in my tests, could you please take a final look on this ? @Meriem-BM |
It also happens on production for one of my accounts @Meriem-BM -This user is an old user Uploading Screen Recording 2024-07-30 at 6.56.19 PM.mov… |
Thanks @maryjaf, can you create a separate issue for this with details, will try to check or ask someone if possible. |
We are adding a 2-part user verification model for qf eligibility. Backend is explained in #4221
This issue is for design. The user flow is essentially:
We will have to consider:
@mosaeedi @koday1 cc @CarlosQ96
The text was updated successfully, but these errors were encountered: