fix: MBD errors #4428

Meriem-BM · 2024-07-17T11:10:16Z

Related to #4247

Gitcoin connect not showing
Refresh score policy to network-only

Summary by CodeRabbit

New Features
- Enhanced eligibility checks and UI feedback for Gitcoin Passport states.
- Updated donation matching prompts to emphasize Quadratic Funding (QF) eligibility verification.
Bug Fixes
- Improved error handling with a new error toast for specific passport states.
Refactor
- Simplified and streamlined component logic for better readability and maintainability.
Documentation
- Updated multilingual text descriptions to clarify the donation and eligibility process.

vercel · 2024-07-17T11:10:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 17, 2024 0:55am

coderabbitai · 2024-07-17T11:10:29Z

Walkthrough

This update enhances the eligibility checking and UI rendering logic across various components by introducing new conditions (MBDEligibile and gitcoinNotConnected) based on qfEligibilityState and passportState. These conditions streamline the handling of eligibility states, improving readability and maintainability. Additionally, some text descriptions were updated to better guide users through the eligibility verification process.

Changes

Files	Summary of Changes
`.../PassportModal.tsx`	Added new conditions for `MBDEligibile` and `gitcoinNotConnected`, refactored existing conditions, and adjusted UI and `useEffect`.
`.../QFEligibility.view.tsx`	Introduced `MBDEligibile` and `gitcoinNotConnected` to simplify logic and improve readability.
`.../QFDonorEligibilityCard.tsx`	Added `MBDEligibile` and `gitcoinNotConnected` conditions, refactored rendering logic for clarity.
`.../usePassport.ts`	Modified `usePassport` function to set `currentRound` based on `info.currentRound`.
`.../passport.ts`	Added `fetchPolicy: 'network-only'` to the `fetchPassportScore` function.
`.../qfEligibility/.../QFToast.tsx`	Simplified logic for generating a description in the `QFToast` component.
`lang/ca.json`, `lang/en.json`, `lang/es.json`	Updated toast descriptions to emphasize checking Quadratic Funding (QF) eligibility before donating.

Poem

In code, we simplify the quest,
For passports and funding, we do our best.
With MBDEligibile, the path is clear,
Gitcoin connects, there's nothing to fear.
Donations flow, the UI bright,
In this new update, we find delight!
🚀✨

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e8a9916 and 9488b54.

Files selected for processing (4)

lang/ca.json (1 hunks)
lang/en.json (1 hunks)
lang/es.json (1 hunks)
src/components/views/donate/QFToast.tsx (2 hunks)

Additional comments not posted (5)

src/components/views/donate/QFToast.tsx (1)

Line range hint 98-110: Approve the styled components.

The styled components use props effectively to adjust styles based on the component state, such as changing the border color based on eligibility. This is a good use of styled-components' capabilities, enhancing the component's modularity and maintainability.
lang/en.json (2)
1298-1298: Typographical Error in Localization Key

The key "infrastrucutre" is misspelled and should be corrected to "infrastructure".
- "infrastrucutre": "Infrastrucutre",
+ "infrastructure": "Infrastructure",
Likely invalid or redundant comment.

1298-1298: Typographical Error in Localization Key

The key "desci" seems to be a typographical error and might be intended to be "desc" or "description".
- "desci": "Desci",
+ "description": "Description",
Likely invalid or redundant comment.
lang/es.json (1)

Line range hint 1-1297: Complete review of Spanish translations JSON file.

The JSON structure is correctly formatted, and the key-value pairs are consistently structured. Each translation appears to be contextually correct based on the keys provided. However, it is essential to ensure that these translations are culturally appropriate and accurately convey the intended meaning in the Spanish language, which might require a native speaker's input.

lang/ca.json (1)

Line range hint 1-1297: Review of JSON Translation File

The JSON file is well-structured and properly formatted. The key-value pairs are consistent, and there are no missing commas or syntax errors. The translations appear to be accurate and consistent with the context provided. However, it's recommended to have a native speaker review to ensure the accuracy and appropriateness of the translations, especially for culturally nuanced phrases.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kkatusic

LGTM ;)

coderabbitai

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)

lang/en.json (1)

1298-1298: Consistency Issue in Localization Keys

The keys for localization should consistently use a similar naming convention. The key "mental-health" uses a hyphen, while most other keys do not. It's important to maintain a consistent format for keys to avoid confusion and potential errors in key references.

Consider standardizing the key format, possibly removing hyphens where not necessary.

coderabbitai · 2024-07-17T12:53:28Z

src/components/views/donate/QFToast.tsx

-					id: `page.donate.passport_toast.description.${
-						isNotEligible ? 'non_eligible' : 'not_connected'
-					}`,
+					id: 'page.donate.passport_toast.description.non_eligible',


Refactor suggestion: Use React Fragment properly for consistency.

The use of React Fragment (<>) here is correct, but for consistency and readability, especially in larger components or projects where JSX structure might be more complex, it's recommended to use the explicit <React.Fragment> notation.

- <> + <React.Fragment> {formatMessage({ id: 'page.donate.passport_toast.description.non_eligible', })}{' '} <span>{endDate}</span> - </> + </React.Fragment>

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

id: 'page.donate.passport_toast.description.non_eligible',

<React.Fragment>

{formatMessage({

id: 'page.donate.passport_toast.description.non_eligible',

})}{' '}

<span>{endDate}</span>

</React.Fragment>

fix: refresh on 2nd attemp & connecting to gitcoin

34af8c0

Meriem-BM requested review from kkatusic and RamRamez July 17, 2024 11:10

fix: remove log

e8a9916

kkatusic approved these changes Jul 17, 2024

View reviewed changes

vercel bot deployed to Preview July 17, 2024 11:22 View deployment

fix: update donation success QF Toast message

9488b54

coderabbitai bot reviewed Jul 17, 2024

View reviewed changes

vercel bot deployed to Preview July 17, 2024 12:55 View deployment

Meriem-BM merged commit 904ed03 into develop Jul 17, 2024
3 checks passed

Meriem-BM deleted the fix/MBD_errors branch July 17, 2024 13:27

This was referenced Sep 15, 2024

Hotfix - fix stellar doante card UI #4734

Merged

Copy changes for GIVbacks eligiblity #4742

Merged

This was referenced Sep 25, 2024

fix: issue 4539, qf shown in donation success page for estimated matching amount #4775

Merged

Revert "fix: issue 4539, qf shown in donation success page for estimated matching amount" #4799

Merged

coderabbitai bot mentioned this pull request Oct 4, 2024

quadratic funding toast on donate success page #4820

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: MBD errors #4428

fix: MBD errors #4428

Meriem-BM commented Jul 17, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 17, 2024 •

edited

Loading

coderabbitai bot commented Jul 17, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

kkatusic left a comment

coderabbitai bot left a comment

coderabbitai bot Jul 17, 2024

-					id: 'page.donate.passport_toast.description.non_eligible',
+			<React.Fragment>
+				{formatMessage({
+					id: 'page.donate.passport_toast.description.non_eligible',
+				})}{' '}
+				<span>{endDate}</span>
+			</React.Fragment>

fix: MBD errors #4428

fix: MBD errors #4428

Conversation

Meriem-BM commented Jul 17, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Jul 17, 2024 • edited Loading

coderabbitai bot commented Jul 17, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

kkatusic left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Jul 17, 2024

Choose a reason for hiding this comment

Meriem-BM commented Jul 17, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 17, 2024 •

edited

Loading

coderabbitai bot commented Jul 17, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)