Assorted justfile and CI workflow maintenance #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the deprecated `--all` option for `cargo nextest` to the recommended (and equivelent) `--workspace` option, in quoted default argument values for recipes in `justfile`. Other occurrences of `--all` to `cargo nextest`, and other commands for which `--all` is a deprecated alias of `--workspace`, were changed to `--workspace` in 14d472d (GitoxideLabs#1654), but I had missed these.
`cargo nextest` will eventually default to `--no-tests=error`, but it doesn't yet. Currently, `cargo nextest run -p gitoxide-core` runs no tests, as there are non in `gitoxide-core` (checked by running `git grep '#.*\[.*test' -- gitoxide-core`). This adds `--no-tests=warn` to that command in the `unit-tests` recipe in `justfile`, to make the default behavior explicit. For CI (but not otherwise), this sets the default to `fail` now by setting the `NEXTEST_NO_TESTS` environment variable. (This is overridden by `--no-tests=warn` so it does not fail `unit-tests`.)
This removes the `ci-test-full` justfile target (see GitoxideLabs#1674), and simplifies and shortens some comments in the justfile, since the distinction between `ci-test` and `ci-test-full` no longer has to be explained, and since some other parts of the comments are no longer applicable (GitoxideLabs#1673).
Byron
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few small improvements to the
ci.ymlworkflow and thejustfile:b9a6fb1 changes
--allto--workspacethat were missed in 14d472d (#1654).2fc93f7 expresses what I think is the intended effect of
nextest run -p ...commands when...has no tests:gitoxide-core, it preserves a warning that will otherwise become an error in a future version ofnextest. (I have verified that this is unaffected by #1674, except that the change there makes the message easier to notice.)eeccb4b removes
ci-test-fullas suggested in #1674 (comment), removes the parenthesized text discussed in #1673, and consolidates accordingly.See the commit messages for further details.