What is the "just-issue of deduplicating targets"?

[EliahKagan]

What does the

(and workaround a just-issue of deduplicating targets)

part of

gitoxide/justfile

Lines 18 to 19 in eedebe7

	# run all journey tests, but assure these are running after `cargo clean` (and workaround a just-issue of deduplicating targets)
	ci-journey-tests: journey-tests-pure journey-tests-small journey-tests-async journey-tests

refer to? Is this saying that it does work around such an issue, or that such an issue should be worked around when using it?

This is relevant to splitting the CI test job that currently calls ci-journey-tests through ci-test (as discussed in #1668 (comment) and #1668 (comment)), which currently depends on it: if I know the answer to this, then I can avoid making the comments less clear, and possibly make them clearer, when making that change. But it shouldn't block a PR for that if the answer is not known.

In case it's relevant (but maybe it's only relevant to the non-parenthesized part that I am not asking about here), ci-journey-tests is currently primarily called through ci-test:

gitoxide/justfile

Lines 15 to 16 in eedebe7

	# run all tests, without clippy, including journey tests, try building docs (and clear target on CI)
	ci-test: check doc unit-tests clear-target ci-journey-tests

And the four rules ci-journey-tests runs are defined as:

gitoxide/justfile

Lines 200 to 222 in eedebe7

	# run journey tests (max)
	journey-tests:
	cargo build --features http-client-curl-rustls
	cargo build -p gix-testtools --bin jtt
	./tests/journey.sh {{ ein }} {{ gix }} {{ jtt }} max
	# run journey tests (max-pure)
	journey-tests-pure:
	cargo build --no-default-features --features max-pure
	cargo build -p gix-testtools --bin jtt
	./tests/journey.sh {{ ein }} {{ gix }} {{ jtt }} max-pure
	# run journey tests (small)
	journey-tests-small:
	cargo build --no-default-features --features small
	cargo build -p gix-testtools
	./tests/journey.sh {{ ein }} {{ gix }} {{ jtt }} small
	# run journey tests (lean-async)
	journey-tests-async:
	cargo build --no-default-features --features lean-async
	cargo build -p gix-testtools
	./tests/journey.sh {{ ein }} {{ gix }} {{ jtt }} async

Is the order, with journey-tests (for max) last, what that parenthesized text in the comment is referring to? It's not clear to me why the order would matter, but it's different from the order in which the dependencies are expressed in ci-journey-tests.

[Byron]

Thanks for bringing this up.
I believe this is an outdated comment, and I don't think it applies anymore. So just removing the parenthesised portion should do be sufficient.

[EliahKagan]

Thanks--I've removed it (among other changes) in #1675.