Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new contrasted color icons. #3

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Add new contrasted color icons. #3

merged 2 commits into from
Jan 5, 2021

Conversation

LazaroOnline
Copy link

Related to this issue:

GitTools/GitVersion#2508

@arturcic
Copy link
Member

arturcic commented Jan 5, 2021

@LazaroOnline could we change a little bit the GitVersion logo by removing the interior white color and only highlight the frame?
https://github.com/GitTools/graphics/blob/29a02ebc7cf795cd6a03e5282eb627a3e0668f34/GitVersion/Color/icon_128x128.png

@LazaroOnline
Copy link
Author

I would prefer to keep the white interior in the tree to remove edge complexity and prevent jagged edges at small scales.
Here is a comparison example of how it would be seen from visual studio:
icon-compare_32

@arturcic
Copy link
Member

arturcic commented Jan 5, 2021

Ok then agree.

@LazaroOnline
Copy link
Author

whops, I forgot to update the icon in the README.md

@arturcic
Copy link
Member

arturcic commented Jan 5, 2021

Ok merging this, would you mind updating the assets in the GitTools/GitVersion and GitTools/actions repo as well?
https://github.com/GitTools/GitVersion/tree/master/docs/input/docs/img
https://github.com/GitTools/GitVersion/blob/master/build/nuspec/GitVersion.Portable.nuspec
https://github.com/GitTools/actions/blob/master/docs/icon.png
https://github.com/GitTools/actions/blob/master/dist/azure/images/icon.png

@arturcic arturcic merged commit f63e54c into GitTools:master Jan 5, 2021
@LazaroOnline LazaroOnline mentioned this pull request Jan 5, 2021
Merged
LazaroOnline added a commit to LazaroOnline/GitVersion that referenced this pull request Jan 5, 2021
@LazaroOnline
Update new color icon.
3e07872 
As per this:
GitTools/graphics#3 (comment)
GitTools#2508
This was referenced Jan 5, 2021
Merged
Merged
arturcic pushed a commit to GitTools/GitVersion that referenced this pull request Jan 5, 2021
@LazaroOnline @arturcic
Update new color icon.
ed43adc 
As per this:
GitTools/graphics#3 (comment)
#2508
@LazaroOnline LazaroOnline mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LazaroOnline @arturcic