-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Make the Nuget package icon in a solid bright color with borders so it can be seen in Visual Studio's dark UI. #2508
Comments
We have a repo for the graphics - https://github.com/GitTools/graphics You can check it out |
I prefer the last one, @GitTools/developers what do you think? |
Also we need the GitTools logo to update in case the GitVersion gets updated |
Yes, I like the last one as well! |
@gep13 what about GRM? Should we update it as well? |
Last one looks better for me and in the same theme as GitVersion |
I really like the ones with white outline as well. Thanks for the time invested in doing this, @LazaroOnline! 🙏🏼 Awesome! 😃 |
Now that GitHub has a dark mode, the documentation will also improve readability by updating the repos to the new icon version. Here is a list of docs to be updated and its location: https://github.com/GitTools/actions#gittools-actions This link cannot be seen in GitHub dark mode: In this one you could use the icon with the color background: The icon link in these repos are broken, I'm not sure what was the icon used before: |
For GitLink, if someone is interested, here is a version following the same scheme: SVG: |
As per this: GitTools/graphics#3 (comment) GitTools#2508
As per this: GitTools/graphics#3 (comment) #2508
This one was archived, now the source code is back into GitVersion |
@LazaroOnline thank you for taking the time, I have updated dockerhub, GitHub organization, updated the gittools/actions Azure and GitHub Action tasks, the nuget packages will get updated on next release |
@arturcic for GRM, we already went a slightly different path, so I don't think an update is required there: https://github.com/GitTools/graphics/blob/master/GitReleaseManager/icon_100x100.png |
We forgot to update the icon in one more location: https://github.com/GitTools/GitVersion/blob/master/docs/input/docs/img/package_icon.png It should get replaced by this one: Can someone with repo access update the image? |
Awesome, @LazaroOnline! Can you please provide the icons in SVG format as well? |
SVG versions are available here if required: |
Make the Nuget package icon in a solid bright color so it can be seen in Visual Studio's dark UI for easier identification and to improve quality perception upon users.
This is how it is seen currently from Visual Studio using the Dark UI:
as an example from Microsoft, they use a bright color with a border around it so that it always has contrast regardless of the background color.
The text was updated successfully, but these errors were encountered: