Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Make the Nuget package icon in a solid bright color with borders so it can be seen in Visual Studio's dark UI. #2508

Closed
LazaroOnline opened this issue Jan 4, 2021 · 17 comments

Comments

@LazaroOnline
Copy link
Contributor

LazaroOnline commented Jan 4, 2021

Make the Nuget package icon in a solid bright color so it can be seen in Visual Studio's dark UI for easier identification and to improve quality perception upon users.

This is how it is seen currently from Visual Studio using the Dark UI:
GitVersion-Icon-VisualStudioDarkUI

as an example from Microsoft, they use a bright color with a border around it so that it always has contrast regardless of the background color.
Microsoft-icon-examples

@arturcic
Copy link
Member

arturcic commented Jan 4, 2021

We have a repo for the graphics - https://github.com/GitTools/graphics You can check it out

@LazaroOnline
Copy link
Contributor Author

Here are some proposals in transparent high-res png:
GitVersionIcon-Circle
GitVersionIcon-Square
GitVersionIcon-Stroke

@arturcic
Copy link
Member

arturcic commented Jan 4, 2021

I prefer the last one, @GitTools/developers what do you think?

@arturcic
Copy link
Member

arturcic commented Jan 4, 2021

Also we need the GitTools logo to update in case the GitVersion gets updated

@gep13
Copy link
Member

gep13 commented Jan 4, 2021

Yes, I like the last one as well!

@arturcic
Copy link
Member

arturcic commented Jan 4, 2021

@gep13 what about GRM? Should we update it as well?

@LazaroOnline
Copy link
Contributor Author

Here are some versions for GitTool also:
GitTool-Square
GitTool-Stroke

@arturcic
Copy link
Member

arturcic commented Jan 4, 2021

Last one looks better for me and in the same theme as GitVersion

@asbjornu
Copy link
Member

asbjornu commented Jan 5, 2021

I really like the ones with white outline as well. Thanks for the time invested in doing this, @LazaroOnline! 🙏🏼 Awesome! 😃

@LazaroOnline
Copy link
Contributor Author

@LazaroOnline
Copy link
Contributor Author

For GitLink, if someone is interested, here is a version following the same scheme:

SVG:
GitLink-svg.zip

128 png:
logo_128

LazaroOnline added a commit to LazaroOnline/GitVersion that referenced this issue Jan 5, 2021
arturcic pushed a commit that referenced this issue Jan 5, 2021
@arturcic
Copy link
Member

arturcic commented Jan 5, 2021

https://github.com/GitTools/GitTools.Testing#gittoolstesting

This one was archived, now the source code is back into GitVersion

@arturcic
Copy link
Member

arturcic commented Jan 5, 2021

@LazaroOnline thank you for taking the time, I have updated dockerhub, GitHub organization, updated the gittools/actions Azure and GitHub Action tasks, the nuget packages will get updated on next release

@arturcic arturcic closed this as completed Jan 5, 2021
@gep13
Copy link
Member

gep13 commented Jan 5, 2021

@arturcic for GRM, we already went a slightly different path, so I don't think an update is required there:

https://github.com/GitTools/graphics/blob/master/GitReleaseManager/icon_100x100.png

@LazaroOnline
Copy link
Contributor Author

We forgot to update the icon in one more location:

https://github.com/GitTools/GitVersion/blob/master/docs/input/docs/img/package_icon.png

It should get replaced by this one:
package_icon

Can someone with repo access update the image?
for binary files GitHub doesn't have a quick edit-and-PR functionality.

@asbjornu
Copy link
Member

asbjornu commented Jan 5, 2021

Awesome, @LazaroOnline! Can you please provide the icons in SVG format as well?

@LazaroOnline
Copy link
Contributor Author

SVG versions are available here if required:
https://github.com/GitTools/graphics/blob/master/GitVersion/Color/icon.svg
https://github.com/GitTools/graphics/blob/master/GitTools/Color/icon.svg

@asbjornu asbjornu mentioned this issue Feb 20, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants